[GitHub] [spark] vinodkc commented on issue #25113: [SPARK-28287][SQL][PYTHON][TESTS] Convert and port 'udaf.sql' into UDF test base

[GitBox <gi...@apache.org>]

vinodkc commented on issue #25113: [SPARK-28287][SQL][PYTHON][TESTS] Convert and port 'udaf.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25113#issuecomment-510502940
 
 
   > @vinodkc,
   > 
   > ```diff
   >  -- !query 2
   > -SELECT default.myDoubleAvg(int_col1) as my_avg from t1
   > +SELECT default.myDoubleAvg(int_col1), default.myDoubleAvg(udf(int_col1)) as my_avg from t1
   >  -- !query 2 schema
   > -struct<my_avg:double>
   > +struct<mydoubleavg(CAST(int_col1 AS DOUBLE)):double,my_avg:double>
   >  -- !query 2 output
   > -102.5
   > +102.5  102.5
   > ```
   > 
   > This one looks a bit weird comparing to the original file.
   
   Fixed the review comment, thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org