[GitHub] [shardingsphere] tristaZero commented on pull request #6263: parse top(expression) for SQLServer query

[GitBox <gi...@apache.org>]

tristaZero commented on pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263#issuecomment-653761832


   Hi @strongduanmu top-notch work! I become to believe in your work more and more!
   
   Thanks to your PR, #6192 will be closed later. 
   
   BTW, this PR just makes `TOP()` parsed well, but this feature also needs more work, like `Rewriting TOP() SQL`.
   
   That is, the next sub-task it to uncomment the SQL cases labeled as `FIXME` and make them run well in `./incubator-shardingsphere/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/test/resources/sharding/select.xml`
   This sub-task will give the contributor a chance to learn more about SQL rewrite module. You know, it the connsequent process after parsing. :-)
   
   Are you interested in this consequent task? I mean, It is not forced, just a question for your interest.
   So please take it easy. Waiting for your response.  :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org