[GitHub] [unomi] giladw commented on a change in pull request #301: UNOMI-472-fix conditionEvaluator inconsistent with elastic for condition when p…

[GitBox <gi...@apache.org>]

giladw commented on a change in pull request #301:
URL: https://github.com/apache/unomi/pull/301#discussion_r652446398



##########
File path: plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluator.java
##########
@@ -206,7 +206,7 @@ protected boolean isMatch(String op, Object actualValue, String expectedValue, O
         if (op == null) {
             return false;
         } else if (actualValue == null) {
-            return op.equals("missing");
+            return op.equals("missing")|| op.equals("notIn") || op.equals("notEquals");

Review comment:
       sorry for the delay, from what i tested, then yes in elastic it handles it this way.
   the way i test it is have 2 tests:
   1. create a segment condition,  then send an event that matches, after validates that the profile is in the segment.
   2. create the event first and then create the segment 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org