You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/08 13:10:33 UTC
[GitHub] [dolphinscheduler] guoshupei opened a new issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
guoshupei opened a new issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
worker received task execute request command and cache 'TaskExecutionContext'，and new Object of 'preTaskCache', but unused. maybe it have other useful？
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1062448290
Yes, I understand the function of cache, but transform to `TaskRequest ` used `taskExecutionContext ` of param instead of `preTaskCache` of new Object（转换TaskRequest使用的是参数中的taskExecutionContext ，而不是new出来的preTaskCache对象，这里preTaskCache是不没有用到呢？）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei edited a comment on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
guoshupei edited a comment on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1062448290
Yes, I understand the function of cache, but transform to `TaskRequest ` used `taskExecutionContext ` of param instead of `preTaskCache` of new Object（转换TaskRequest使用的是参数中的taskExecutionContext ，而不是new出来的preTaskCache对象，这里preTaskCache是不没有用到呢？）@caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong closed issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
zhuangchong closed issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1061760934
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1062778174
> Yes, I understand the function of cache, but transform to `TaskRequest ` used `taskExecutionContext ` of param instead of `preTaskCache` of new Object（转换TaskRequest使用的是参数中的taskExecutionContext ，而不是new出来的preTaskCache对象，这里preTaskCache是不没有用到呢？
Yes, you are right, I read it wrong before. Looking forward to your pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei removed a comment on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
guoshupei removed a comment on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1062448290
Yes, I understand the function of cache, but transform to `TaskRequest ` used `taskExecutionContext ` of param instead of `preTaskCache` of new Object（转换TaskRequest使用的是参数中的taskExecutionContext ，而不是new出来的preTaskCache对象，这里preTaskCache是不没有用到呢？）@caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1061865845
It was used to transform to `TaskRequest` and keep in cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1064705352
> > Yes, I understand the function of cache, but transform to `TaskRequest ` used `taskExecutionContext ` of param instead of `preTaskCache` of new Object（转换TaskRequest使用的是参数中的taskExecutionContext ，而不是new出来的preTaskCache对象，这里preTaskCache是不没有用到呢？
>
> Yes, you are right, I read it wrong before. Looking forward to your pr.
Hi @caishunfeng , when issue was token by someone, should better assign issue to him/her. then we can see assigned in the issue lists
<img width="1248" alt="image" src="https://user-images.githubusercontent.com/15820530/157789567-243374ec-0ca9-45a8-96a8-a0a4792d936e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #8758: [Improvement] [dolphinscheduler-worker] the object 'preTaskCache' is never used, Suggested deletion
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #8758:
URL: https://github.com/apache/dolphinscheduler/issues/8758#issuecomment-1062713751
> It was used to transform to `TaskRequest` and keep in cache.
Yes, I understand the function of cache, but transform to `TaskRequest ` used `taskExecutionContext ` of param instead of `preTaskCache` of new Object（转换TaskRequest使用的是参数中的taskExecutionContext ，而不是new出来的preTaskCache对象，这里preTaskCache是不没有用到呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org