You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wagon-dev@maven.apache.org by Brett Porter <br...@apache.org> on 2006/12/11 22:25:43 UTC
Re: svn commit: r485724 - in /maven/wagon/trunk/wagon-providers/wagon-http-shared: pom.xml src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java src/main/java/org/apache/maven/wagon/shared/http/NullOutputStream.java
It's not just size that matters...
Anything used from wagon-http-lightweight will currently be
distributed in the core. That means that plugins will be forced to
use the version you distribute. I could see this as a problem for jtidy.
Is there anyway you can do this with just JDK 1.4 methods without
considerable duplication of that code?
- Brett
On 12/12/2006, at 2:51 AM, joakime@apache.org wrote:
> Author: joakime
> Date: Mon Dec 11 07:51:43 2006
> New Revision: 485724
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=485724
> Log:
> Moving away from nekohtml and its hard xerces requirement due to
> maven 2 xerces dependency size issues.
> Using smaller jtidy instead.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org
Re: svn commit: r485724 - in /maven/wagon/trunk/wagon-providers/wagon-http-shared: pom.xml src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java src/main/java/org/apache/maven/wagon/shared/http/NullOutputStream.java
Posted by Jason van Zyl <ja...@maven.org>.
On 11 Dec 06, at 6:36 PM 11 Dec 06, Joakim Erdfelt wrote:
> Real world html parsing is not easy.
> I would rather not create yet another implementation.
> We went from nekohtml (with it's xerces requirement) at 8.1MB to jtidy
> (with jre/jaxp support) at 135KB.
> I think this is an adequate reduction.
> Best bang for the buck, etc...
>
I think we will eventually get it out of the core anyway. With rate
at which the container is improving it should be fully backward
compatible shortly and have adequate isolation and loading
capabilities to get things like doxia and wagon out of the core.
jason.
> - Joakim
>
> Brett Porter wrote:
>> Well, it's a blocker on upgrading it in Maven, that's all, until one
>> thing is sorted out. I wouldn't think any mangling should be truly
>> necessary - we should be able to put the wagon implementation
>> stuff in
>> a separate classloader rather than the one the plugins derive from
>> anyway. But it's all Maven changes.
>>
>> If everyone is happy with that, then it's fine to go ahead and
>> release
>> it.
>>
>> - Brett
>>
>> On 12/12/2006, at 8:52 AM, Jason van Zyl wrote:
>>
>>> On 11 Dec 06, at 4:25 PM 11 Dec 06, Brett Porter wrote:
>>>
>>>> It's not just size that matters...
>>>>
>>>> Anything used from wagon-http-lightweight will currently be
>>>> distributed in the core. That means that plugins will be forced to
>>>> use the version you distribute. I could see this as a problem for
>>>> jtidy.
>>>>
>>>
>>> I will be able to mangle anything non-public. This theoretically
>>> should not be a problem as I would like to pull xstream back into
>>> plexus and that would be a big problem as well.
>>>
>>>> Is there anyway you can do this with just JDK 1.4 methods without
>>>> considerable duplication of that code?
>>>
>>> If it can be done great, but the size is down and we should be able
>>> to work some ASM magic.
>>>
>>> Jason.
>>>
>>>>
>>>> - Brett
>>>>
>>>> On 12/12/2006, at 2:51 AM, joakime@apache.org wrote:
>>>>
>>>>> Author: joakime
>>>>> Date: Mon Dec 11 07:51:43 2006
>>>>> New Revision: 485724
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=485724
>>>>> Log:
>>>>> Moving away from nekohtml and its hard xerces requirement due to
>>>>> maven 2 xerces dependency size issues.
>>>>> Using smaller jtidy instead.
>>>>>
>>>>
>>>> -------------------------------------------------------------------
>>>> --
>>>> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>>>>
>>>>
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org
Re: svn commit: r485724 - in /maven/wagon/trunk/wagon-providers/wagon-http-shared:
pom.xml src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java
src/main/java/org/apache/maven/wagon/shared/http/NullOutputStream.java
Posted by Joakim Erdfelt <jo...@erdfelt.com>.
Real world html parsing is not easy.
I would rather not create yet another implementation.
We went from nekohtml (with it's xerces requirement) at 8.1MB to jtidy
(with jre/jaxp support) at 135KB.
I think this is an adequate reduction.
Best bang for the buck, etc...
- Joakim
Brett Porter wrote:
> Well, it's a blocker on upgrading it in Maven, that's all, until one
> thing is sorted out. I wouldn't think any mangling should be truly
> necessary - we should be able to put the wagon implementation stuff in
> a separate classloader rather than the one the plugins derive from
> anyway. But it's all Maven changes.
>
> If everyone is happy with that, then it's fine to go ahead and release
> it.
>
> - Brett
>
> On 12/12/2006, at 8:52 AM, Jason van Zyl wrote:
>
>> On 11 Dec 06, at 4:25 PM 11 Dec 06, Brett Porter wrote:
>>
>>> It's not just size that matters...
>>>
>>> Anything used from wagon-http-lightweight will currently be
>>> distributed in the core. That means that plugins will be forced to
>>> use the version you distribute. I could see this as a problem for
>>> jtidy.
>>>
>>
>> I will be able to mangle anything non-public. This theoretically
>> should not be a problem as I would like to pull xstream back into
>> plexus and that would be a big problem as well.
>>
>>> Is there anyway you can do this with just JDK 1.4 methods without
>>> considerable duplication of that code?
>>
>> If it can be done great, but the size is down and we should be able
>> to work some ASM magic.
>>
>> Jason.
>>
>>>
>>> - Brett
>>>
>>> On 12/12/2006, at 2:51 AM, joakime@apache.org wrote:
>>>
>>>> Author: joakime
>>>> Date: Mon Dec 11 07:51:43 2006
>>>> New Revision: 485724
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=485724
>>>> Log:
>>>> Moving away from nekohtml and its hard xerces requirement due to
>>>> maven 2 xerces dependency size issues.
>>>> Using smaller jtidy instead.
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org
Re: svn commit: r485724 - in /maven/wagon/trunk/wagon-providers/wagon-http-shared: pom.xml src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java src/main/java/org/apache/maven/wagon/shared/http/NullOutputStream.java
Posted by Brett Porter <br...@apache.org>.
Well, it's a blocker on upgrading it in Maven, that's all, until one
thing is sorted out. I wouldn't think any mangling should be truly
necessary - we should be able to put the wagon implementation stuff
in a separate classloader rather than the one the plugins derive from
anyway. But it's all Maven changes.
If everyone is happy with that, then it's fine to go ahead and
release it.
- Brett
On 12/12/2006, at 8:52 AM, Jason van Zyl wrote:
> On 11 Dec 06, at 4:25 PM 11 Dec 06, Brett Porter wrote:
>
>> It's not just size that matters...
>>
>> Anything used from wagon-http-lightweight will currently be
>> distributed in the core. That means that plugins will be forced to
>> use the version you distribute. I could see this as a problem for
>> jtidy.
>>
>
> I will be able to mangle anything non-public. This theoretically
> should not be a problem as I would like to pull xstream back into
> plexus and that would be a big problem as well.
>
>> Is there anyway you can do this with just JDK 1.4 methods without
>> considerable duplication of that code?
>
> If it can be done great, but the size is down and we should be able
> to work some ASM magic.
>
> Jason.
>
>>
>> - Brett
>>
>> On 12/12/2006, at 2:51 AM, joakime@apache.org wrote:
>>
>>> Author: joakime
>>> Date: Mon Dec 11 07:51:43 2006
>>> New Revision: 485724
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=485724
>>> Log:
>>> Moving away from nekohtml and its hard xerces requirement due to
>>> maven 2 xerces dependency size issues.
>>> Using smaller jtidy instead.
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: wagon-dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org
Re: svn commit: r485724 - in /maven/wagon/trunk/wagon-providers/wagon-http-shared: pom.xml src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java src/main/java/org/apache/maven/wagon/shared/http/NullOutputStream.java
Posted by Jason van Zyl <ja...@maven.org>.
On 11 Dec 06, at 4:25 PM 11 Dec 06, Brett Porter wrote:
> It's not just size that matters...
>
> Anything used from wagon-http-lightweight will currently be
> distributed in the core. That means that plugins will be forced to
> use the version you distribute. I could see this as a problem for
> jtidy.
>
I will be able to mangle anything non-public. This theoretically
should not be a problem as I would like to pull xstream back into
plexus and that would be a big problem as well.
> Is there anyway you can do this with just JDK 1.4 methods without
> considerable duplication of that code?
If it can be done great, but the size is down and we should be able
to work some ASM magic.
Jason.
>
> - Brett
>
> On 12/12/2006, at 2:51 AM, joakime@apache.org wrote:
>
>> Author: joakime
>> Date: Mon Dec 11 07:51:43 2006
>> New Revision: 485724
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=485724
>> Log:
>> Moving away from nekohtml and its hard xerces requirement due to
>> maven 2 xerces dependency size issues.
>> Using smaller jtidy instead.
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: wagon-dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org