You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2026/06/30 08:54:54 UTC

[PR] [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

raulcd opened a new pull request, #50301:
URL: https://github.com/apache/arrow/pull/50301

   ### Rationale for this change
   
   The meson job is currently failing due to not finding header for include on flatbuffers generated file. This works on CMake because we have: `include_directories(src/generated)` and didn't failed previously on Meson because we used the full `generated/xxx.h` file.
   
   ### What changes are included in this PR?
   
   Add path to include so meson can also find the header without requiring to also include generated directory.
   
   ### Are these changes tested?
   
   Via CI
   
   ### Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4842000028

   @github-actions crossbow submit wheel-manylinux-2-28-cp314-cp314-amd64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4841906946

   :warning: GitHub issue #50300 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4842017204

   Revision: 0811c9d27d4ac3060cbbd6f3b30f3efbfc2b05c9
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-6f1f900867](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6f1f900867)
   
   |Task|Status|
   |----|------|
   |wheel-manylinux-2-28-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-6f1f900867-github-wheel-manylinux-2-28-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/28435369274/job/84259907666)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Update include to generated/Message_generated.h so Meson is able to find [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #50301:
URL: https://github.com/apache/arrow/pull/50301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Update include to generated/Message_generated.h so Meson is able to find [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4842732456

   > Do we want to remove `include_directories(src/generated)` so as to make the CMake and Meson setups more similar?
   
   Makes sense to me, I've pushed the removal of the `include_directories`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4842006333

   The crossbow submit job is unrelated. I am trying to reproduce an issue that happened on the nightlies which I can't reproduce locally, see for more details:
   - https://github.com/apache/arrow/issues/50291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4841615285

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #50301:
URL: https://github.com/apache/arrow/pull/50301#discussion_r3497763255


##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -24,7 +24,7 @@
 
 #include <gtest/gtest.h>
 
-#include "Message_generated.h"
+#include "generated/Message_generated.h"

Review Comment:
   The PR title/description say the fix is to add the flatbuffers generated path to Meson include dirs so `#include "Message_generated.h"` works. This change instead switches the source to `#include "generated/Message_generated.h"` (matching other IPC sources) and does not address Meson include paths. Please align the PR description/title with the actual fix, or (if the intention is to avoid `generated/` in includes) keep the include as `Message_generated.h` and update Meson/CMake include paths accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Update include path so Meson is able to find generated/Message_generated.h [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4842247422

   Do we want to remove `include_directories(src/generated)` so as to make the CMake and Meson setups more similar?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Update include to generated/Message_generated.h so Meson is able to find [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4858278339

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0cf9e0358eb07ca2f312581b430e87febd837592.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/84595347955) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50301:
URL: https://github.com/apache/arrow/pull/50301#issuecomment-4841997045

   The meson job is currently successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50300: [C++][CI] Update include path so Meson is able to find generated/Message_generated.h [arrow]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #50301:
URL: https://github.com/apache/arrow/pull/50301#discussion_r3497817065


##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -24,7 +24,7 @@
 
 #include <gtest/gtest.h>
 
-#include "Message_generated.h"
+#include "generated/Message_generated.h"

Review Comment:
   The PR title/description say Meson is fixed by adding an include path so code can keep including "Message_generated.h" without the `generated/` prefix, but this change instead updates the source include to `"generated/Message_generated.h"`. Please update the PR title/description to match the actual fix (or implement the include-dir change if that was the intent) to avoid confusion for reviewers and future archaeology.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org