You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Anonymitaet (via GitHub)" <gi...@apache.org> on 2023/08/26 03:41:08 UTC

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #680: [improve][doc] SEO for Pulsar functions

Anonymitaet commented on code in PR #680:
URL: https://github.com/apache/pulsar-site/pull/680#discussion_r1306309580


##########
docs/functions-develop-security.md:
##########
@@ -2,19 +2,22 @@
 id: functions-develop-security
 title: Enable security on functions
 sidebar_label: "Enable security on functions"
+description: Learn to enable security on functions in Pulsar.
 ---
 
 ````mdx-code-block
 import Tabs from '@theme/Tabs';
 import TabItem from '@theme/TabItem';
 ````
 
+If you want to enable security on functions, complete the following steps:

Review Comment:
   ```suggestion
   If you want to enable security on functions, complete the following steps.
   ```



##########
docs/functions-develop-tutorial.md:
##########
@@ -50,6 +53,8 @@ The following example is a stateful function. By default, the state of a functio
 
 ## Write a function for content-based routing
 
+To write a function for content-based routing, complete the following steps:

Review Comment:
   ```suggestion
   To write a function for content-based routing, complete the following steps.
   ```



##########
docs/functions-develop-tutorial.md:
##########
@@ -12,6 +13,8 @@ The following example is a stateful function. By default, the state of a functio
 
 :::
 
+To write a function for word count, complete the following steps:

Review Comment:
   ```suggestion
   To write a function for word count, complete the following steps.
   ```



##########
docs/functions-worker-stateful.md:
##########
@@ -10,6 +11,8 @@ When the stateful APIs of Pulsar Functions are required – for example, `putSta
 
 :::
 
+To enable the stateful function feature in function workers, complete the following steps:

Review Comment:
   ```suggestion
   To enable the stateful function feature in function workers, complete the following steps.
   ```



##########
docs/functions-develop-security.md:
##########
@@ -2,19 +2,22 @@
 id: functions-develop-security
 title: Enable security on functions
 sidebar_label: "Enable security on functions"
+description: Learn to enable security on functions in Pulsar.
 ---
 
 ````mdx-code-block
 import Tabs from '@theme/Tabs';
 import TabItem from '@theme/TabItem';
 ````
 
+If you want to enable security on functions, complete the following steps:
+
 ## Prerequisites
 
-If you want to enable security on functions, you need to [enable security settings](functions-worker.md) on function workers first.
+- you need to [enable security settings](functions-worker.md) on function workers first.

Review Comment:
   I believe the original text is more accurate because "enable security" might be optional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org