You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/15 21:45:08 UTC

[GitHub] [arrow] aocsa commented on pull request #11164: ARROW-14003: [Python] Not providing a sort_key in the "select_k_unstable" kernel crashes

aocsa commented on pull request #11164:
URL: https://github.com/apache/arrow/pull/11164#issuecomment-920404356


   > If it does not makes sense to invoke `select_k_unstable` without providing a `k` and `sort_keys`, then also make these parameters mandatory in the [`SelectKOptions`](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_vector.h#L126).
   > 
   > Although, client code can still provide an invalid value of `k` and an empty vector to `sort_keys`, it expresses the desired intent.
   
   You are right, however there is a requirement to have a default constructor enabled to implement copy here:  
   https://github.com/apache/arrow/blob/4fde2068051f43e1639777f289b5ab83cb6bf6f9/cpp/src/arrow/compute/function_internal.h#L634
   
   I think this was a a design decision to implement a general copy method with the registered properties. 
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org