You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "deepak dixit (JIRA)" <ji...@apache.org> on 2011/03/23 09:30:06 UTC

[jira] [Created] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Lookup target-parameter in form widget is not working.
------------------------------------------------------

                 Key: OFBIZ-4225
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 10.04, SVN trunk
            Reporter: deepak dixit
            Priority: Minor
             Fix For: Release Branch 10.04, SVN trunk


There is a target-parameter for lookup, Currently its not working.
We can test it over at https://localhost:8443/ordermgr/control/request page. 


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010663#comment-13010663 ] 

Jacques Le Roux commented on OFBIZ-4225:
----------------------------------------

Hi Deepak,

Thinking more about it I have changed my mine. I will rather revert and use 0 as origin because some custom applications are certainly using it. 

I noticed you changed also for viewName in R10.04. So it was another mixed problem isn'it?

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010176#comment-13010176 ] 

Deepak Dixit commented on OFBIZ-4225:
-------------------------------------

Thanks Jacques.

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011094#comment-13011094 ] 

Deepak Dixit commented on OFBIZ-4225:
-------------------------------------

For trunk its correct Jacques, We can start indexing with 0 and then its works fine. Sorry for the confusion.
If we using index 0 then we have to fix the LookupPreferredContactMech screen to get parameter with parameters.parm0 instead of parameters.parm1.

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit reopened OFBIZ-4225:
---------------------------------


> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_BRANCH_IMPROVE.patch, OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch, OFBIZ-4225_TRUNK_IMPROVE.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "deepak dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

deepak dixit updated OFBIZ-4225:
--------------------------------

    Attachment: OFBIZ-4225_FOR_TRUNK.patch
                OFBIZ-4225_FOR_BRANCH10.04.patch

Here I am attaching patch for fix the current workflow of target-parameter.


> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: deepak dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit resolved OFBIZ-4225.
---------------------------------

    Resolution: Fixed

Now its working fine, Thanks Jaques and Leon.

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit reopened OFBIZ-4225:
---------------------------------


> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-4225:
--------------------------------

    Attachment: OFBIZ-4225_TRUNK_IMPROVE.patch
                OFBIZ-4225_BRANCH_IMPROVE.patch

Here is the improved patch for target-parameter functionality, now pam indexing start with 0 instead of 1.

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_BRANCH_IMPROVE.patch, OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch, OFBIZ-4225_TRUNK_IMPROVE.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4225.
----------------------------------

    Resolution: Fixed

Thanks Deepak,

Your patch is in trunk at r1085671, R10.04 at r1085670.

I have updated the XSD to tell it must begin at 0

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_BRANCH_IMPROVE.patch, OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch, OFBIZ-4225_TRUNK_IMPROVE.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4225.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks a bunch Deepak,

I did not get a chance to look at it, great!

Your patches are respectively in trunk at r1084574, R10.04 at r1084572

I have added a small change in the XSD to tell it should begin at 1

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Leon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011892#comment-13011892 ] 

Leon commented on OFBIZ-4225:
-----------------------------

What a long story ^^. Since the .xsd has been updated, I think this time parm0 would nevever change to parm1 again. I can apply the patch comfortablely.

Thank you all.


> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_BRANCH_IMPROVE.patch, OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch, OFBIZ-4225_TRUNK_IMPROVE.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011620#comment-13011620 ] 

Deepak Dixit commented on OFBIZ-4225:
-------------------------------------

Thanks Jacques.

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_BRANCH_IMPROVE.patch, OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch, OFBIZ-4225_TRUNK_IMPROVE.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011091#comment-13011091 ] 

Deepak Dixit commented on OFBIZ-4225:
-------------------------------------

Thanks Jacques for looking into this,

But IMP its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again.

And I did not change the view name, I only change the if condition;
For 10.04
Earlier it checks for args.lenght > 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup.

For Trunk:
The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing.

IMO it is a bug so we have to fix it and the patch will fix the problem.
Please let me know it the fix is wrong and there is some improvement needed in patch.

> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (OFBIZ-4225) Lookup target-parameter in form widget is not working.

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011091#comment-13011091 ] 

Deepak Dixit edited comment on OFBIZ-4225 at 3/25/11 4:16 AM:
--------------------------------------------------------------

Thanks Jacques for looking into this,

But IMO its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again.

And I did not change the view name, I only change the if condition;
For 10.04
Earlier it checks for args.lenght > 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup.

For Trunk:
The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing.

IMO it is a bug so we have to fix it and the patch will fix the problem.
Please let me know it the fix is wrong and there is some improvement needed in patch.

      was (Author: deepakdixit):
    Thanks Jacques for looking into this,

But IMP its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again.

And I did not change the view name, I only change the if condition;
For 10.04
Earlier it checks for args.lenght > 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup.

For Trunk:
The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing.

IMO it is a bug so we have to fix it and the patch will fix the problem.
Please let me know it the fix is wrong and there is some improvement needed in patch.
  
> Lookup target-parameter in form widget is not working.
> ------------------------------------------------------
>
>                 Key: OFBIZ-4225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch
>
>
> There is a target-parameter for lookup, Currently its not working.
> We can test it over at https://localhost:8443/ordermgr/control/request page. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira