[jira] [Commented] (MYFACES-3459) RegexValidator does not provide label and pattern for first usage of RegexValidator.NOT_MATCHED

["Martin Kočí (Commented JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200046#comment-13200046 ] 

Martin Kočí commented on MYFACES-3459:
--------------------------------------

few observations:

# java.util.regex.Pattern.matcher(CharSequence) support CharSequence and we can easily support it  too -> change instanceof check to "(value instanceof CharSequence)"

# this instanceof check indicates disagreement between local value (converted) and type expected in validator - created '{1}: Validation Error: Value not according to pattern ''{0}''' is not suitable for this (mojarra thows CastClassExpception in the middle of validator and that is also not very proper)

# javax.faces.validator.RegexValidator.PATTERN_NOT_SET and RegexValidator.MATCH_EXCEPTION are completely missing in .properties files - or I can't find them


                
> RegexValidator does not provide label and pattern for first usage of RegexValidator.NOT_MATCHED
> -----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3459
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3459
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.1.5
>         Environment: myfaces trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Trivial
>
> RegexValidator uses javax.faces.validator.RegexValidator.NOT_MATCHED 2x:
> javax.faces.validator.RegexValidator.NOT_MATCHED= the passed value is not a String, or when the pattern does not match the passed value.
> the first usage for" if (value instanceof String)" check does not provide args for {0} {1} in message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira