[GitHub] [orc] nehaljwani commented on a change in pull request #524: ZSTD_STATIC_LIB_NAME: Avoid double .a extensions

[GitBox <gi...@apache.org>]

nehaljwani commented on a change in pull request #524:
URL: https://github.com/apache/orc/pull/524#discussion_r468267702



##########
File path: cmake_modules/FindZSTD.cmake
##########
@@ -24,7 +24,7 @@ endif()
 message (STATUS "ZSTD_HOME: ${ZSTD_HOME}")
 
 if (NOT ZSTD_STATIC_LIB_NAME)
-  set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd)
+  set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd${CMAKE_STATIC_LIBRARY_SUFFIX})

Review comment:
       It doesn't, however, depending on the order of items in the value of `CMAKE_FIND_LIBRARY_SUFFIXES`, it can pick up the shared library here (`libzstd.so`) and then fail later, while linking statically. IMO we should close this PR and open an issue to support linking third party dependency dynamically and statically, both.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org