You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/18 03:07:47 UTC

[GitHub] [avro] blachniet commented on a change in pull request #1006: AVRO-2980: Use PackageIcon in C# dist

blachniet commented on a change in pull request #1006:
URL: https://github.com/apache/avro/pull/1006#discussion_r525702195



##########
File path: lang/csharp/common.props
##########
@@ -45,6 +46,7 @@
 
   <ItemGroup>
     <None Include="$(MSBuildThisFileDirectory)\LICENSE" Pack="true" Visible="false" PackagePath=""/>
+    <None Include="$(MSBuildThisFileDirectory)/../../doc/src/resources/images/avro-logo.png" Pack="true" PackagePath="\"/>

Review comment:
       Could you set `Visible="false"` in this, like with did with `LICENSE` above? That prevents this file from appearing in the project tree view in Visual Studio. I think `PackagePath` should be empty like in `LICENSE` as well. Did you get an error with it being blank?
   
   ```suggestion
       <None Include="$(MSBuildThisFileDirectory)/../../doc/src/resources/images/avro-logo.png" Pack="true" Visible="false" PackagePath=""/>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org