You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "claudevdm (via GitHub)" <gi...@apache.org> on 2026/04/08 20:21:41 UTC
[PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
claudevdm opened a new pull request, #38114:
URL: https://github.com/apache/beam/pull/38114
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on code in PR #38114:
URL: https://github.com/apache/beam/pull/38114#discussion_r3053976141
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1010,7 +1010,7 @@ public static Sink sink(Schema schema) {
.setPageSize(ParquetWriter.DEFAULT_PAGE_SIZE)
.setEnableDictionary(ParquetWriter.DEFAULT_IS_DICTIONARY_ENABLED)
.setEnableBloomFilter(ParquetProperties.DEFAULT_BLOOM_FILTER_ENABLED)
- .setMinRowCountForPageSizeCheck(ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK)
+ .setMinRowCountForPageSizeCheck(ValueProvider.StaticValueProvider.of(null))
Review Comment:
Just rely on default parquet settings instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38114:
URL: https://github.com/apache/beam/pull/38114#discussion_r3053968866
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1109,6 +1110,20 @@ public Sink withBloomFilterEnabled(boolean enableBloomFilter) {
public Sink withMinRowCountForPageSizeCheck(int minRowCountForPageSizeCheck) {
checkArgument(
minRowCountForPageSizeCheck > 0, "minRowCountForPageSizeCheck must be positive");
+ return toBuilder()
+ .setMinRowCountForPageSizeCheck(
+ ValueProvider.StaticValueProvider.of(minRowCountForPageSizeCheck))
+ .build();
+ }
+
+ /**
+ * Like {@link #withMinRowCountForPageSizeCheck(int)}, but accepts a {@link ValueProvider} so
+ * the value can be supplied at runtime (required for classic Dataflow templates).
+ */
+ public Sink withMinRowCountForPageSizeCheck(
+ ValueProvider<Integer> minRowCountForPageSizeCheck) {
+ checkArgument(
+ minRowCountForPageSizeCheck != null, "minRowCountForPageSizeCheck must not be null");
return toBuilder().setMinRowCountForPageSizeCheck(minRowCountForPageSizeCheck).build();
}
Review Comment:
When providing a `ValueProvider`, it is good practice to validate the value if it is accessible at pipeline construction time (e.g., for `StaticValueProvider`). This ensures consistency with the `int` version of the method.
```suggestion
public Sink withMinRowCountForPageSizeCheck(
ValueProvider<Integer> minRowCountForPageSizeCheck) {
checkArgument(
minRowCountForPageSizeCheck != null, "minRowCountForPageSizeCheck must not be null");
if (minRowCountForPageSizeCheck.isAccessible() && minRowCountForPageSizeCheck.get() != null) {
checkArgument(
minRowCountForPageSizeCheck.get() > 0, "minRowCountForPageSizeCheck must be positive");
}
return toBuilder().setMinRowCountForPageSizeCheck(minRowCountForPageSizeCheck).build();
}
```
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1141,8 +1156,12 @@ public void open(WritableByteChannel channel) throws IOException {
.withRowGroupSize(getRowGroupSize())
.withPageSize(getPageSize())
.withDictionaryEncoding(getEnableDictionary())
- .withBloomFilterEnabled(getEnableBloomFilter())
- .withMinRowCountForPageSizeCheck(getMinRowCountForPageSizeCheck());
+ .withBloomFilterEnabled(getEnableBloomFilter());
+
+ Integer minRowCount = getMinRowCountForPageSizeCheck().get();
+ if (minRowCount != null) {
+ builder = builder.withMinRowCountForPageSizeCheck(minRowCount);
+ }
Review Comment:
Added a runtime check to ensure `minRowCount` is positive when resolved from the `ValueProvider`. This provides a clearer error message if an invalid value is provided at runtime.
```suggestion
Integer minRowCount = getMinRowCountForPageSizeCheck().get();
if (minRowCount != null) {
checkArgument(minRowCount > 0, "minRowCountForPageSizeCheck must be positive");
builder = builder.withMinRowCountForPageSizeCheck(minRowCount);
}
```
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1010,7 +1010,7 @@ public static Sink sink(Schema schema) {
.setPageSize(ParquetWriter.DEFAULT_PAGE_SIZE)
.setEnableDictionary(ParquetWriter.DEFAULT_IS_DICTIONARY_ENABLED)
.setEnableBloomFilter(ParquetProperties.DEFAULT_BLOOM_FILTER_ENABLED)
- .setMinRowCountForPageSizeCheck(ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK)
+ .setMinRowCountForPageSizeCheck(ValueProvider.StaticValueProvider.of(null))
Review Comment:
The default value for `minRowCountForPageSizeCheck` was changed from `ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK` to `null`. It is better to maintain the explicit default value to ensure consistent behavior and clarity.
```suggestion
.setMinRowCountForPageSizeCheck(
ValueProvider.StaticValueProvider.of(ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on PR #38114:
URL: https://github.com/apache/beam/pull/38114#issuecomment-4209356401
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38114:
URL: https://github.com/apache/beam/pull/38114#discussion_r3054100335
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1010,7 +1010,6 @@ public static Sink sink(Schema schema) {
.setPageSize(ParquetWriter.DEFAULT_PAGE_SIZE)
.setEnableDictionary(ParquetWriter.DEFAULT_IS_DICTIONARY_ENABLED)
.setEnableBloomFilter(ParquetProperties.DEFAULT_BLOOM_FILTER_ENABLED)
- .setMinRowCountForPageSizeCheck(ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK)
Review Comment:
The default value for `minRowCountForPageSizeCheck` should be preserved to maintain consistent behavior and ensure that the getter does not return `null` for a default `Sink`. Since the field now expects a `ValueProvider`, you should wrap the default constant in a `StaticValueProvider`.
```suggestion
.setMinRowCountForPageSizeCheck(ValueProvider.StaticValueProvider.of(ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38114:
URL: https://github.com/apache/beam/pull/38114#issuecomment-4209350940
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the ParquetIO connector by introducing support for ValueProvider in the minRowCountForPageSizeCheck configuration. This change allows users to supply this parameter at runtime, which is a requirement for compatibility with classic Dataflow templates. The internal logic was updated to handle the potential nullability of the ValueProvider, ensuring robust integration with the existing Parquet writer configuration.
### Highlights
* **ValueProvider Support**: Updated the ParquetIO Sink to support ValueProvider for the minRowCountForPageSizeCheck configuration, enabling runtime value injection.
* **API Expansion**: Added an overloaded withMinRowCountForPageSizeCheck method to the Sink class to accept ValueProvider<Integer>.
* **Logic Adjustment**: Modified the open method to safely retrieve the value from the ValueProvider and apply it only if present.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on PR #38114:
URL: https://github.com/apache/beam/pull/38114#issuecomment-4209532143
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm merged PR #38114:
URL: https://github.com/apache/beam/pull/38114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38114:
URL: https://github.com/apache/beam/pull/38114#discussion_r3054081989
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1109,6 +1109,23 @@ public Sink withBloomFilterEnabled(boolean enableBloomFilter) {
public Sink withMinRowCountForPageSizeCheck(int minRowCountForPageSizeCheck) {
checkArgument(
minRowCountForPageSizeCheck > 0, "minRowCountForPageSizeCheck must be positive");
+ return toBuilder()
+ .setMinRowCountForPageSizeCheck(
+ ValueProvider.StaticValueProvider.of(minRowCountForPageSizeCheck))
+ .build();
+ }
+
+ /**
+ * Like {@link #withMinRowCountForPageSizeCheck(int)}, but accepts a {@link ValueProvider} so
+ * the value can be supplied at runtime (required for classic Dataflow templates).
+ */
+ public Sink withMinRowCountForPageSizeCheck(
+ ValueProvider<Integer> minRowCountForPageSizeCheck) {
+ checkNotNull(minRowCountForPageSizeCheck, "minRowCountForPageSizeCheck can not be null");
+ if (minRowCountForPageSizeCheck.isAccessible()) {
+ checkArgument(
+ minRowCountForPageSizeCheck.get() > 0, "minRowCountForPageSizeCheck must be positive");
Review Comment:
The value from `minRowCountForPageSizeCheck.get()` can be `null`, which would cause a `NullPointerException` during unboxing for the comparison. It's better to check for `null` explicitly and fail fast with a clear error message if a `null` value is provided when the `ValueProvider` is accessible at graph construction time.
```java
Integer value = minRowCountForPageSizeCheck.get();
checkNotNull(value, "minRowCountForPageSizeCheck value cannot be null");
checkArgument(value > 0, "minRowCountForPageSizeCheck must be positive");
```
##########
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java:
##########
@@ -1141,8 +1158,14 @@ public void open(WritableByteChannel channel) throws IOException {
.withRowGroupSize(getRowGroupSize())
.withPageSize(getPageSize())
.withDictionaryEncoding(getEnableDictionary())
- .withBloomFilterEnabled(getEnableBloomFilter())
- .withMinRowCountForPageSizeCheck(getMinRowCountForPageSizeCheck());
+ .withBloomFilterEnabled(getEnableBloomFilter());
+
+ ValueProvider<Integer> minRowCountProvider = getMinRowCountForPageSizeCheck();
+ if (minRowCountProvider != null) {
+ int minRowCount = minRowCountProvider.get();
+ checkArgument(minRowCount > 0, "minRowCountForPageSizeCheck must be positive");
+ builder = builder.withMinRowCountForPageSizeCheck(minRowCount);
Review Comment:
The value from `minRowCountProvider.get()` can be `null`, which would cause a `NullPointerException` when unboxing to `int`. It's safer to get it as an `Integer` and check for null. If the value is `null`, it's reasonable to do nothing and let the underlying writer use its default.
```java
Integer minRowCount = minRowCountProvider.get();
if (minRowCount != null) {
checkArgument(minRowCount > 0, "minRowCountForPageSizeCheck must be positive");
builder = builder.withMinRowCountForPageSizeCheck(minRowCount);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38114:
URL: https://github.com/apache/beam/pull/38114#issuecomment-4209369038
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on PR #38114:
URL: https://github.com/apache/beam/pull/38114#issuecomment-4209358257
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MinRowCountForPageSizeCheck available with ValueProvider [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on PR #38114:
URL: https://github.com/apache/beam/pull/38114#issuecomment-4209560752
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org