[jira] Commented: (ZOOKEEPER-958) Flag to turn off autoconsume in hedwig c++ client

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971601#action_12971601 ] 

Hadoop QA commented on ZOOKEEPER-958:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12466301/ZOOKEEPER-958.diff
  against trunk revision 1049401.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/68//console

This message is automatically generated.

> Flag to turn off autoconsume in hedwig c++ client
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-958
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-958
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-hedwig
>    Affects Versions: 3.3.2
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.3.3
>
>         Attachments: ZOOKEEPER-958.diff
>
>
> Currently the hedwig cpp client will automatically send a consume message to the server when the calling client indicated that it has received the message. If the client wants to queue the messages and not acknowledge them to the server immediately, they need to block, which means interfering with any other running callbacks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.