You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by foryou2030 <gi...@git.apache.org> on 2016/09/26 08:30:55 UTC

[GitHub] incubator-carbondata pull request #198: [CARBONDATA-273]Using carbon common ...

GitHub user foryou2030 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/198

    [CARBONDATA-273]Using carbon common constants instead of direct values

    # Why raise this pr?
    there are some constants hav been defined in CarbonCommonConstants, but sitill using its direct value in the code.
    # How to solve?
    Using carbon common constants instead of direct values


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/foryou2030/incubator-carbondata utf8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #198
    
----
commit 28ea756774f43e76b6988a96451aa8b13993e83a
Author: foryou2030 <fo...@126.com>
Date:   2016-09-26T08:25:38Z

    use carbon common constants instead of direct values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #198: [CARBONDATA-273]Using carbon common ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/198


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---