You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/11/30 09:58:38 UTC
Review Request 54197: Introduced Resource.AllocationInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54197/
-----------------------------------------------------------
Review request for mesos, Guangya Liu and Qiang Zhang.
Bugs: MESOS-6633
https://issues.apache.org/jira/browse/MESOS-6633
Repository: mesos
Description
-------
To determine which role resources are allocated to, we now need to
store allocation information within the Resources. This if part of
the effort to support multi-role frameworks. See MESOS-6633 for more
details.
Diffs
-----
include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
Diff: https://reviews.apache.org/r/54197/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54197: Introduced Resource.AllocationInfo.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54197/#review157519
-----------------------------------------------------------
Fix it, then Ship it!
There is a typo in `Description` section: s/This if/This is
include/mesos/mesos.proto (lines 787 - 793)
<https://reviews.apache.org/r/54197/#comment228143>
How about the following to make it less jagged?
```
message AllocationInfo {
// If set, this resource is allocated to a role. Note that in the
// future, this may be unset and the scheduler may be responsible
// for allocating to one of its roles.
optional string role = 1;
// In the future, we may add additional fields here, e.g. priority
// tier, type of allocation (quota / fair share).
}
```
- Guangya Liu
On \u5341\u4e00\u6708 30, 2016, 9:58 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54197/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e00\u6708 30, 2016, 9:58 a.m.)
>
>
> Review request for mesos, Guangya Liu and Qiang Zhang.
>
>
> Bugs: MESOS-6633
> https://issues.apache.org/jira/browse/MESOS-6633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To determine which role resources are allocated to, we now need to
> store allocation information within the Resources. This if part of
> the effort to support multi-role frameworks. See MESOS-6633 for more
> details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
> include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
>
> Diff: https://reviews.apache.org/r/54197/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54197: Introduced Resource.AllocationInfo.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54197/#review157669
-----------------------------------------------------------
Fix it, then Ship it!
Looks good, just a small suggestion about adding a warning for users that we're still implementing this and that non MULTI_ROLE frameworks can still assume they are being offered resources allocated to their single role.
include/mesos/mesos.proto (lines 786 - 796)
<https://reviews.apache.org/r/54197/#comment228302>
How about adding a warning to these (v1 and unversioned):
```
// This was initially introduced to support MULTI_ROLE capable
// frameworks. Frameworks that are not MULTI_ROLE capable can
// continue to assume that the offered resources are allocated
// to their role.
//
// NOTE: Implementation of this is in-progress, DO NOT USE!
message AllocationInfo {
```
- Benjamin Mahler
On Dec. 1, 2016, 2:47 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54197/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 2:47 a.m.)
>
>
> Review request for mesos, Guangya Liu and Qiang Zhang.
>
>
> Bugs: MESOS-6633
> https://issues.apache.org/jira/browse/MESOS-6633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To determine which role resources are allocated to, we now need to
> store allocation information within the Resources. This is part of
> the effort to support multi-role frameworks. See MESOS-6633 for more
> details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
> include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
>
> Diff: https://reviews.apache.org/r/54197/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54197: Introduced Resource.AllocationInfo.
Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54197/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 2:47 a.m.)
Review request for mesos, Guangya Liu and Qiang Zhang.
Changes
-------
addressed guangya's comment
Bugs: MESOS-6633
https://issues.apache.org/jira/browse/MESOS-6633
Repository: mesos
Description (updated)
-------
To determine which role resources are allocated to, we now need to
store allocation information within the Resources. This is part of
the effort to support multi-role frameworks. See MESOS-6633 for more
details.
Diffs (updated)
-----
include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
Diff: https://reviews.apache.org/r/54197/diff/
Testing
-------
Thanks,
Jay Guo