You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "manstis (via GitHub)" <gi...@apache.org> on 2023/03/02 16:38:07 UTC
[GitHub] [camel-kamelets] manstis opened a new issue, #1330: Deprecating parameters
manstis opened a new issue, #1330:
URL: https://github.com/apache/camel-kamelets/issues/1330
By way of a real example, let me explain the issue:
The Camel Slack Component has deprecated some [Query Parameters](https://camel.apache.org/components/3.20.x/slack-component.html#_path_parameters_1_parameters), namely `iconEmoji`, `iconUrl` and `username`.
Ideally the corresponding [Slack Sink Kamelet](https://camel.apache.org/camel-kamelets/3.20.x/slack-sink.html) needs the parameters to be marked as deprecated too so Users are aware that they may be removed in a future release.
However the underlying [`Kamelet.KameletSpec.JSONSCHEMAPROPS.JSONSCHEMAPROP`](https://camel.apache.org/camel-k/1.12.x/apis/kamelets.html#_camel_apache_org_v1alpha1_JSONSchemaProp) does not support indicating that a parameter is deprecated.
What can we do?
Add a property to https://camel.apache.org/camel-k/1.12.x/apis/kamelets.html#_camel_apache_org_v1alpha1_JSONSchemaProp
Propose use of an `x-descriptor` to indicate the parameter is deprecated? What would it be?
Where would we also need to presumably change Kamelet documentation generation to use the new property or x-descriptor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on issue #1330: Deprecating parameters
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on issue #1330:
URL: https://github.com/apache/camel-kamelets/issues/1330#issuecomment-1452198974
I'll gather some idea like where to change the documentation generation and the schema. Thanks for helping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] manstis commented on issue #1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on issue #1330:
URL: https://github.com/apache/camel-kamelets/issues/1330#issuecomment-1452195865
Hi @oscerd I realise it's new.
I'm happy to collaborate as best I can; but am likely to need a little direction.
You may have guessed I'm new to Kamelets (and Camel as a whole too) but am eager to be useful.
I assume there's a process and this issue is likely to need discussion and a solution agreed.
If you're happy guiding, I'm happy helping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on issue #1330: Deprecating parameters
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on issue #1330:
URL: https://github.com/apache/camel-kamelets/issues/1330#issuecomment-1452188087
As of today there is no concept of deprecation in Kamelets parameters nor on Kamelets in general. So this would be something completely new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on issue #1330: Deprecating parameters
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on issue #1330:
URL: https://github.com/apache/camel-kamelets/issues/1330#issuecomment-1452254413
This is where the documentation is generated for each Kamelet
https://github.com/apache/camel-kamelets/blob/main/docs/modules/ROOT/examples/js/kamelets.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] manstis commented on issue #1330: Deprecating parameters
Posted by "manstis (via GitHub)" <gi...@apache.org>.
manstis commented on issue #1330:
URL: https://github.com/apache/camel-kamelets/issues/1330#issuecomment-1453288694
See https://github.com/apache/camel-k/pull/4097
I couldn't get the validation to use a local version of `camel/v1alpha1/Kamelet` for love nor money.
I'll keep trying (I'm learning Go too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] squakez closed issue #1330: Deprecating parameters
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #1330: Deprecating parameters
URL: https://github.com/apache/camel-kamelets/issues/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org