You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 04:42:44 UTC
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #107: feat: add configmap for deploy
gxthrj opened a new pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#issuecomment-747864318
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=h1) Report
> Merging [#107](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=desc) (e9e2bdf) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/cfbed0a16505c4d85316a225076e8fdaf5f8db5a?el=desc) (cfbed0a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 60.53% 60.53%
=======================================
Files 16 16
Lines 527 527
=======================================
Hits 319 319
Misses 184 184
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=footer). Last update [cfbed0a...e9e2bdf](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#issuecomment-747879402
do we need to fix this PR in milestone `0.1.0`?
if yes, please set the right milestone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#discussion_r545575087
##########
File path: samples/deploy/configmap/apisix-ingress-cm.yaml
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: v1
+data:
+ config.yaml: |
+ # log options
+ log_level: "info" # the error log level, default is info, optional values are:
+ # debug
+ # info
+ # warn
+ # error
+ # panic
+ # fatal
+ log_output: "stderr" # the output file path of error log, default is stderr, when
+ # the file path is "stderr" or "stdout", logs are marshalled
+ # plainly, which is more readable for human; otherwise logs
+ # are marshalled in JSON format, which can be parsed by
+ # programs easily.
+
+ http_listen: ":8080" # the HTTP Server listen address, default is ":8080"
+ enable_profiling: true # enable profileing via web interfaces
+ # host:port/debug/pprof, default is true.
+
+ # Kubernetes related configurations.
+ kubernetes:
+ kubeconfig: "" # the Kubernetes configuration file path, default is
+ # "", so the in-cluster configuration will be used.
+ resync_interval: "60s" # how long should apisix-ingress-controller
+ # re-synchronizes with Kubernetes, default is 60s,
+ # and the minimal resync interval is 30s.
+
+ # APISIX related configurations.
+ apisix:
+ base_url: "http://127.0.0.1:9080/apisix/admin" # the APISIX admin api / manager api
+ # base url, it's required.
+kind: ConfigMap
+metadata:
+ name: apisix-ingress-cm
Review comment:
Always add line break af the end of file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#issuecomment-747880216
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#discussion_r545584158
##########
File path: samples/deploy/configmap/apisix-ingress-cm.yaml
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: v1
+data:
+ config.yaml: |
+ # log options
+ log_level: "info" # the error log level, default is info, optional values are:
+ # debug
+ # info
+ # warn
+ # error
+ # panic
+ # fatal
+ log_output: "stderr" # the output file path of error log, default is stderr, when
+ # the file path is "stderr" or "stdout", logs are marshalled
+ # plainly, which is more readable for human; otherwise logs
+ # are marshalled in JSON format, which can be parsed by
+ # programs easily.
+
+ http_listen: ":8080" # the HTTP Server listen address, default is ":8080"
+ enable_profiling: true # enable profileing via web interfaces
+ # host:port/debug/pprof, default is true.
+
+ # Kubernetes related configurations.
+ kubernetes:
+ kubeconfig: "" # the Kubernetes configuration file path, default is
+ # "", so the in-cluster configuration will be used.
+ resync_interval: "60s" # how long should apisix-ingress-controller
+ # re-synchronizes with Kubernetes, default is 60s,
+ # and the minimal resync interval is 30s.
+
+ # APISIX related configurations.
+ apisix:
+ base_url: "http://127.0.0.1:9080/apisix/admin" # the APISIX admin api / manager api
+ # base url, it's required.
+kind: ConfigMap
+metadata:
+ name: apisix-ingress-cm
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#issuecomment-747864318
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=h1) Report
> Merging [#107](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=desc) (c5fb4d4) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/cfbed0a16505c4d85316a225076e8fdaf5f8db5a?el=desc) (cfbed0a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 60.53% 60.53%
=======================================
Files 16 16
Lines 527 527
=======================================
Hits 319 319
Misses 184 184
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=footer). Last update [cfbed0a...c5fb4d4](https://codecov.io/gh/apache/apisix-ingress-controller/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #107: feat: add configmap for deploy
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #107:
URL: https://github.com/apache/apisix-ingress-controller/pull/107#issuecomment-747877154
@gxthrj The license checker failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org