You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2012/01/16 10:54:35 UTC
svn commit: r1231886 -
/tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
Author: markt
Date: Mon Jan 16 09:54:35 2012
New Revision: 1231886
URL: http://svn.apache.org/viewvc?rev=1231886&view=rev
Log:
Review comments from kkolinko
Modified:
tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java?rev=1231886&r1=1231885&r2=1231886&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java Mon Jan 16 09:54:35 2012
@@ -108,7 +108,7 @@ public class JMXProxyServlet extends Htt
if (ps == null) {
valuesStr = new String[0];
} else {
- valuesStr = request.getParameter("ps").split(",");
+ valuesStr = ps.split(",");
}
invokeOperation( writer, qry, opName,valuesStr );
return;
@@ -129,7 +129,7 @@ public class JMXProxyServlet extends Htt
writer.println("OK - Attribute get '" + onameStr + "' - " + att
+ "= " + MBeanDumper.escape(value.toString()));
} catch (Exception ex) {
- writer.println("Error");
+ writer.println("Error - " + ex.toString());
ex.printStackTrace(writer);
}
}
@@ -144,7 +144,7 @@ public class JMXProxyServlet extends Htt
mBeanServer.setAttribute( oname, new Attribute(att, valueObj));
writer.println("OK - Attribute set");
} catch( Exception ex ) {
- writer.println("Error");
+ writer.println("Error - " + ex.toString());
ex.printStackTrace(writer);
}
}
@@ -158,7 +158,7 @@ public class JMXProxyServlet extends Htt
writer.println("OK - Number of results: " + names.size());
writer.println();
} catch (Exception ex) {
- writer.println("Error");
+ writer.println("Error - " + ex.toString());
ex.printStackTrace(writer);
return;
}
@@ -196,7 +196,7 @@ public class JMXProxyServlet extends Htt
writer.println("OK - Operation " + op + " returned:");
output("", writer, retVal);
} catch( Exception ex ) {
- writer.println("Error");
+ writer.println("Error - " + ex.toString());
ex.printStackTrace(writer);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org