You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/09/19 16:14:54 UTC
Review Request 68768: Fixed disconnection while sending
acknowledgment to IOSwitchboard.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68768/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-8545
https://issues.apache.org/jira/browse/MESOS-8545
Repository: mesos
Description
-------
Previously, an HTTP connection to the IOSwitchboard could be garbage
collected before the agent sent an acknowledgment to the IOSwitchboard
via this connection. This patch fixes the issue by keeping a reference
count to the connection in a lambda callback until disconnection
occurs.
Diffs
-----
src/slave/http.cpp bf34ef75f8f25cf895d1c4d52923b2d6254f1ecc
Diff: https://reviews.apache.org/r/68768/diff/1/
Testing
-------
1. sudo make check (Fedora 25)
2. internal CI
Thanks,
Andrei Budnik
Re: Review Request 68768: Fixed disconnection while sending
acknowledgment to IOSwitchboard.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68768/#review208853
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 19, 2018, 4:14 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68768/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2018, 4:14 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, an HTTP connection to the IOSwitchboard could be garbage
> collected before the agent sent an acknowledgment to the IOSwitchboard
> via this connection. This patch fixes the issue by keeping a reference
> count to the connection in a lambda callback until disconnection
> occurs.
>
>
> Diffs
> -----
>
> src/slave/http.cpp bf34ef75f8f25cf895d1c4d52923b2d6254f1ecc
>
>
> Diff: https://reviews.apache.org/r/68768/diff/1/
>
>
> Testing
> -------
>
> 1. sudo make check (Fedora 25)
> 2. internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 68768: Fixed disconnection while sending
acknowledgment to IOSwitchboard.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68768/#review208769
-----------------------------------------------------------
PASS: Mesos patch 68768 was successfully built and tested.
Reviews applied: `['68768']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2357/mesos-review-68768
- Mesos Reviewbot Windows
On Sept. 19, 2018, 4:14 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68768/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2018, 4:14 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, an HTTP connection to the IOSwitchboard could be garbage
> collected before the agent sent an acknowledgment to the IOSwitchboard
> via this connection. This patch fixes the issue by keeping a reference
> count to the connection in a lambda callback until disconnection
> occurs.
>
>
> Diffs
> -----
>
> src/slave/http.cpp bf34ef75f8f25cf895d1c4d52923b2d6254f1ecc
>
>
> Diff: https://reviews.apache.org/r/68768/diff/1/
>
>
> Testing
> -------
>
> 1. sudo make check (Fedora 25)
> 2. internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>