You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Vitaly Baranovsky (JIRA)" <je...@portals.apache.org> on 2008/01/12 14:10:34 UTC
[jira] Created: (JS2-848) Portlet decorator comboboxes doesn't
displays current decorator name (and tiny performance degradation)
Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)
-------------------------------------------------------------------------------------------------------
Key: JS2-848
URL: https://issues.apache.org/jira/browse/JS2-848
Project: Jetspeed 2
Issue Type: Bug
Components: Customizer
Affects Versions: 2.1.3
Reporter: Vitaly Baranovsky
When I change decorator of some portlet using the customizer, decorator changes without any problem, but name of decorator doesn't displays in decorator combobox of customizer.
The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
Problem is in code (2 times per this file):
#if (!$f.Decorator)
#set ($fd = $f.Decorator)
#end
You should change first line of this code block to
#if($f.Decorator).
Also, there is code block:
#foreach($pd in $decorationFactory.getPortletDecorations($rc))
#set ($fd = "")
#if (!$f.Decorator)
#set ($fd = $f.Decorator)
#end
<option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
#end
</select>
code of setting $fd is inside the cycle, but $fd is never changes inside this cycle. So, there is a good idea to move this setting block before cycle.
Patch that solves this problem is attached to this JIRA record.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Assigned: (JS2-848) Portlet decorator comboboxes doesn't
displays current decorator name (and tiny performance degradation)
Posted by "Vivek Kumar (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vivek Kumar reassigned JS2-848:
-------------------------------
Assignee: Vivek Kumar
> Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)
> -------------------------------------------------------------------------------------------------------
>
> Key: JS2-848
> URL: https://issues.apache.org/jira/browse/JS2-848
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Customizer
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Assignee: Vivek Kumar
> Attachments: layout_vm.patch
>
>
> When I change decorator of some portlet using the customizer, decorator changes without any problem, but name of decorator doesn't displays in decorator combobox of customizer.
> The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
> Problem is in code (2 times per this file):
> #if (!$f.Decorator)
> #set ($fd = $f.Decorator)
> #end
> You should change first line of this code block to
> #if($f.Decorator).
> Also, there is code block:
> #foreach($pd in $decorationFactory.getPortletDecorations($rc))
> #set ($fd = "")
> #if (!$f.Decorator)
> #set ($fd = $f.Decorator)
> #end
> <option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
> #end
> </select>
> code of setting $fd is inside the cycle, but $fd is never changes inside this cycle. So, there is a good idea to move this setting block before cycle.
> Patch that solves this problem is attached to this JIRA record.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Updated: (JS2-848) Portlet decorator comboboxes doesn't
displays current decorator name (and tiny performance degradation)
Posted by "Vitaly Baranovsky (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vitaly Baranovsky updated JS2-848:
----------------------------------
Attachment: layout_vm.patch
> Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)
> -------------------------------------------------------------------------------------------------------
>
> Key: JS2-848
> URL: https://issues.apache.org/jira/browse/JS2-848
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Customizer
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Attachments: layout_vm.patch
>
>
> When I change decorator of some portlet using the customizer, decorator changes without any problem, but name of decorator doesn't displays in decorator combobox of customizer.
> The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
> Problem is in code (2 times per this file):
> #if (!$f.Decorator)
> #set ($fd = $f.Decorator)
> #end
> You should change first line of this code block to
> #if($f.Decorator).
> Also, there is code block:
> #foreach($pd in $decorationFactory.getPortletDecorations($rc))
> #set ($fd = "")
> #if (!$f.Decorator)
> #set ($fd = $f.Decorator)
> #end
> <option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
> #end
> </select>
> code of setting $fd is inside the cycle, but $fd is never changes inside this cycle. So, there is a good idea to move this setting block before cycle.
> Patch that solves this problem is attached to this JIRA record.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Resolved: (JS2-848) Portlet decorator comboboxes doesn't
displays current decorator name (and tiny performance degradation)
Posted by "Vivek Kumar (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vivek Kumar resolved JS2-848.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.2
Patch applied Thanks Vitaly Baranovsky
> Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)
> -------------------------------------------------------------------------------------------------------
>
> Key: JS2-848
> URL: https://issues.apache.org/jira/browse/JS2-848
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Customizer
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Assignee: Vivek Kumar
> Fix For: 2.2
>
> Attachments: layout_vm.patch
>
>
> When I change decorator of some portlet using the customizer, decorator changes without any problem, but name of decorator doesn't displays in decorator combobox of customizer.
> The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
> Problem is in code (2 times per this file):
> #if (!$f.Decorator)
> #set ($fd = $f.Decorator)
> #end
> You should change first line of this code block to
> #if($f.Decorator).
> Also, there is code block:
> #foreach($pd in $decorationFactory.getPortletDecorations($rc))
> #set ($fd = "")
> #if (!$f.Decorator)
> #set ($fd = $f.Decorator)
> #end
> <option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
> #end
> </select>
> code of setting $fd is inside the cycle, but $fd is never changes inside this cycle. So, there is a good idea to move this setting block before cycle.
> Patch that solves this problem is attached to this JIRA record.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org