You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2018/02/16 14:45:32 UTC
Re: Review Request 65655: Updated Mesos CLI test base to use shell to
start masters and agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65655/#review197671
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Feb. 14, 2018, 4:17 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65655/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 4:17 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We use the shell scripts in `build/src` to start masters and agents
> for the CLI tests. Instead of running them as executable, we now use
> shell to interprete them using the new Executable attribute 'shell'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/tests/base.py 33c67c1161d9c9fd57aa5f44b04746e3740e1dd9
>
>
> Diff: https://reviews.apache.org/r/65655/diff/2/
>
>
> Testing
> -------
>
> Checked that `mesos-cli-tests` was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>