svn commit: r1181583 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

[ns...@apache.org]

Author: nspiegelberg
Date: Tue Oct 11 02:22:42 2011
New Revision: 1181583

URL: http://svn.apache.org/viewvc?rev=1181583&view=rev
Log:
Fixing per-CF metrics for Put/Delete/Get due to ":" separator

Summary:
Apparently on parsing the strings in the metrics maps, the ":" separator causes
problems and invalidates the entry. This caused the actual metrics for the
requests to not show up at all.

Test Plan:
I just ran a multi-CF put against the cluster and checked the machine serving
the region for the metrics to show up:

"hadoop.regionserver_cf.aaa~bbb.multiput_avgtime": 2,
"hadoop.regionserver_cf.aaa~bbb.multiput_maxtime": 2,
"hadoop.regionserver_cf.aaa~bbb.multiput_mintime": 2,
"hadoop.regionserver_cf.aaa~bbb.multiput_numops": 0,

Reviewed By: kannan
Reviewers: kannan
CC: kannan
Differential Revision: 275602

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=1181583&r1=1181582&r2=1181583&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Tue Oct 11 02:22:42 2011
@@ -289,7 +289,7 @@ public class HRegion implements HeapSize
       --limit;
       sb.append(Bytes.toString(family));
       if (0 != limit) {
-        sb.append(":");
+        sb.append("~");
       }
     }