[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1221: HDDS-1488. Scm cli command to start/stop replication manager.

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #1221: HDDS-1488. Scm cli command to start/stop replication manager.
URL: https://github.com/apache/hadoop/pull/1221#discussion_r310374189
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
 ##########
 @@ -469,6 +469,27 @@ public boolean forceExitSafeMode() throws IOException {
     return scm.exitSafeMode();
   }
 
+  @Override
+  public void startReplicationManager() {
+    AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+        SCMAction.START_REPLICATION_MANAGER, null));
+    scm.getReplicationManager().start();
+  }
+
+  @Override
+  public void stopReplicationManager() {
+    AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+        SCMAction.STOP_REPLICATION_MANAGER, null));
+    scm.getReplicationManager().stop();
 
 Review comment:
   Stop is an idempotent call and also it's async, so getting status of ReplicationManager immediately after calling stop might some time return true (running).
   
   > Like case calling stop on already stopped replication monitor, we can print like Replication Monitor is not running
   
   If we do this, we can end up in a minor inconsistency for a short period of time. Where stop will say that ReplicationManager is not running, but the status command will say that ReplicationManager is running.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org