You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/03 06:53:05 UTC
[GitHub] [pulsar] StevenLuMT opened a new pull request #13113: cleanup code for ZkBookieRackAffinityMapping
StevenLuMT opened a new pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113
Descriptions of the changes in this PR:
### Motivation
Simple code cleanup
### Modifications
1. no use import UnknownHostException for ZkBookieRackAffinityMapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj edited a comment on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
Shoothzj edited a comment on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985290258
The master doesn't have this problem at now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985290811
>
In my memory, this config of checkstyle only checks file that modified not every file in the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985289779
I see checkstyle shows 63 errors for `pulsar-zookkeeper-utils`, including unused imports. (the one @StevenLuMT is fixing in this PR)
Is there any reason why we don't strictly follow checkstyle and attach it at the compile phase in every sub-projects? @eolivelli @lhotari @codelipenghui @merlimat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985290811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-994467550
> This class was already deleted/refactored in master branch
Sorry @StevenLuMT I will close the PR for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985290258
The master doesn't have this problem at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985650798
This class was already deleted/refactored in master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-986364349
@StevenLuMT for the doc side, this PR cleanup codes, so no need to update docs, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985295570
@nicoloboschi I think we have some component have not apply the check style yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985296076
@StevenLuMT could you please help resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13113: cleanup code for ZkBookieRackAffinityMapping
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13113:
URL: https://github.com/apache/pulsar/pull/13113#issuecomment-985261461
@StevenLuMT:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org