You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/02/09 19:36:30 UTC
[GitHub] couchdb-fauxton pull request: Design tweaks
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/643
Design tweaks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton design-tweaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #643
----
commit a5962264c4544f82b23cb1d465ab2c72b401a630
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-02-09T18:09:24Z
query-options: adjust width of toggle buttons
commit b7b3cf466ed35bf3e419b65254724ff88e7ee28d
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-02-09T18:34:40Z
cors: fix hover of icons
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design tweaks
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/643#discussion_r52396080
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -173,8 +173,8 @@ function (app, FauxtonAPI, React, ReactDOM, Stores, Actions, Components) {
<div className="query-group" id="query-options-key-search">
<div className="add-on">Keys</div>
<div className="btn-group toggle-btns row-fluid">
- <label id="byKeys" onClick={this.toggleByKeys} className={byKeysButtonClass}>By Key(s)</label>
- <label id="betweenKeys" onClick={this.toggleBetweenKeys} className={betweenKeysButtonClass}>Between Keys</label>
+ <label style={{width: '101px'}} id="byKeys" onClick={this.toggleByKeys} className={byKeysButtonClass}>By Key(s)</label>
+ <label style={{width: '101px'}} id="betweenKeys" onClick={this.toggleBetweenKeys} className={betweenKeysButtonClass}>Between Keys</label>
--- End diff --
However, there are a lot of other styles particular to this component that aren't inline. For consistency, if they're in both places I'd prefer keeping it in just the one. Just my preference - I don't object to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design tweaks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/643
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design tweaks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/643#discussion_r52352379
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -173,8 +173,8 @@ function (app, FauxtonAPI, React, ReactDOM, Stores, Actions, Components) {
<div className="query-group" id="query-options-key-search">
<div className="add-on">Keys</div>
<div className="btn-group toggle-btns row-fluid">
- <label id="byKeys" onClick={this.toggleByKeys} className={byKeysButtonClass}>By Key(s)</label>
- <label id="betweenKeys" onClick={this.toggleBetweenKeys} className={betweenKeysButtonClass}>Between Keys</label>
+ <label style={{width: '101px'}} id="byKeys" onClick={this.toggleByKeys} className={byKeysButtonClass}>By Key(s)</label>
+ <label style={{width: '101px'}} id="betweenKeys" onClick={this.toggleBetweenKeys} className={betweenKeysButtonClass}>Between Keys</label>
--- End diff --
i like the use of react-inline-styles here as this is style which is specific to this item
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design tweaks
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/643#issuecomment-182139518
Looks good, +1 when green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---