You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/22 16:42:31 UTC
[GitHub] GJL commented on issue #7529: [hotfix] [blob] Generalize usage of
NoOpTransientBlobService
GJL commented on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService
URL: https://github.com/apache/flink/pull/7529#issuecomment-456470455
Are you planning to use the `NoOpTransientBlobService` somewhere else? If not, I would not like to merge this PR. I find it hard to believe that an implementation that throws an exception for almost every method can be used for testing in a sensible way. Also `enum` are a common strategy to implement singletons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services