You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/01 06:33:11 UTC

[GitHub] [pulsar-client-cpp] RobertIndie commented on a diff in pull request #66: Add new interfaces to improve data consuming performance. (#65)

RobertIndie commented on code in PR #66:
URL: https://github.com/apache/pulsar-client-cpp/pull/66#discussion_r1010110403


##########
tests/MessageTest.cc:
##########
@@ -53,6 +53,8 @@ TEST(MessageTest, testAllocatedContents) {
     Message msg = msgBuilder.build();
     ASSERT_FALSE(strncmp("content", (char*)msg.getData(), msg.getLength()));
     ASSERT_EQ(content, (char*)msg.getData());
+
+    ASSERT_THROW(msg.releaseData(), std::runtime_error);

Review Comment:
   Please add a test case for releasing the data successfully and verify the data is actually swapped.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org