You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2006/12/18 10:07:42 UTC
Re: [classlib][security] Whether to update the signed.bcprov.jar?
On 18 December 2006 at 13:43, "Alexey Varlamov" <al...@gmail.com> wrote:
> Stepan,
>
> I thougth we agreed to drop "signed" prefix. See also comment in the
> depends.properties:
> --------------------
> # will the next person to update bcprov.jar please remove the "signed."
> # prefix from the bcprov.jar property
> bcprov.dir=${depends.jars}/bcprov-jdk15-134
> bcprov.jar=${bcprov.dir}/signed.bcprov.jar
> --------------------
Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
step that we needed a while back. I couldn't remove the prefix without
making unnecessary work for developers so I left it to be removed next
time developers had to fetch a new version.
-Mark.
> 2006/12/18, Stepan Mishura <st...@gmail.com>:
> > On 12/14/06, Leo Li wrote:
> > >
> > > Hi, all:
> > > When fixing the bug of Harmony-2678, I found Harmony fails to get the
> > > AlgorithmParameters for the algorithm "OAEP" because of the
> > > signed.bcprov.jar used lacks a class called "
> > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But it exist
> s
> > > in the latest release version of Bouncy Castle and I replace the current
> > > used jar with bcprov-jdk15-134.jar and everything is OK.
> > > So shall we update the signed.bcprov.jar? If it is, I will give a
> > > patch to the renew the make/depends.properties.
> >
> >
> > Hi Leo,
> >
> > I've applied your patch for upgrading version of Bounce Castle provider
> > (from HARMONY-2678).
> >
> > Thanks,
> > Stepan.
> >
> > --
> > > Leo Li
> > > China Software Development Lab, IBM
> > >
> > >
> >
> >
> > --
> > Stepan Mishura
> > Intel Enterprise Solutions Software Division
> >
> >
>
Re: [classlib][security] Whether to update the signed.bcprov.jar?
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Stepan Mishura wrote:
> On 12/18/06, Mark Hindess wrote:
>>
>>
>> On 18 December 2006 at 13:43, "Alexey Varlamov" wrote:
>> > Stepan,
>> >
>> > I thougth we agreed to drop "signed" prefix. See also comment in the
>> > depends.properties:
>> > --------------------
>> > # will the next person to update bcprov.jar please remove the "signed."
>> > # prefix from the bcprov.jar property
>> > bcprov.dir=${depends.jars}/bcprov-jdk15-134
>> > bcprov.jar=${bcprov.dir}/signed.bcprov.jar
>> > --------------------
>>
>> Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
>> step that we needed a while back. I couldn't remove the prefix without
>> making unnecessary work for developers so I left it to be removed next
>> time developers had to fetch a new version.
>
>
> Mark, sorry about that. I forgot to remove the prefix in the last moment.
>
> BTW, what do you mean by saying "I couldn't remove the prefix without
> making
> unnecessary work for developers"?
And, is this something we can just decide to grit our teeth and do it so
we don't have this same conversation in a month ? :)
geir
>
> Thanks,
> Stepan.
>
> -Mark.
>>
>> > 2006/12/18, Stepan Mishura <st...@gmail.com>:
>> > > On 12/14/06, Leo Li wrote:
>> > > >
>> > > > Hi, all:
>> > > > When fixing the bug of Harmony-2678, I found Harmony fails to
>> get the
>> > > > AlgorithmParameters for the algorithm "OAEP" because of the
>> > > > signed.bcprov.jar used lacks a class called "
>> > > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But it
>> exist
>> > s
>> > > > in the latest release version of Bouncy Castle and I replace the
>> current
>> > > > used jar with bcprov-jdk15-134.jar and everything is OK.
>> > > > So shall we update the signed.bcprov.jar? If it is, I will
>> give
>> a
>> > > > patch to the renew the make/depends.properties.
>> > >
>> > >
>> > > Hi Leo,
>> > >
>> > > I've applied your patch for upgrading version of Bounce Castle
>> provider
>> > > (from HARMONY-2678).
>> > >
>> > > Thanks,
>> > > Stepan.
>> > >
>>
>>
>>
>
Re: [classlib][security] Whether to update the signed.bcprov.jar?
Posted by Mark Hindess <ma...@googlemail.com>.
On 18 December 2006 at 20:16, "Stepan Mishura" <st...@gmail.com> wrote:
>
> On 12/18/06, Mark Hindess wrote:
> >
> > On 18 December 2006 at 13:43, "Alexey Varlamov" wrote:
> > > Stepan,
> > >
> > > I thougth we agreed to drop "signed" prefix. See also comment in the
> > > depends.properties:
> > > --------------------
> > > # will the next person to update bcprov.jar please remove the "signed."
> > > # prefix from the bcprov.jar property
> > > bcprov.dir=${depends.jars}/bcprov-jdk15-134
> > > bcprov.jar=${bcprov.dir}/signed.bcprov.jar
> > > --------------------
> >
> > Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
> > step that we needed a while back. I couldn't remove the prefix without
> > making unnecessary work for developers so I left it to be removed next
> > time developers had to fetch a new version.
>
>
> Mark, sorry about that. I forgot to remove the prefix in the last moment.
>
> BTW, what do you mean by saying "I couldn't remove the prefix without making
> unnecessary work for developers"?
Well, there was already a bcprov.jar which was the unsigned version
so that file already existed and would need to be removed so that the
signed version could be renamed (or downloaded by fetch-depends for new
developers). I suppose I could have done it in ant, but that would have
meant writing some code (quite a bit probably) that I/we would have
to remember to remove later. I thought just writing the comment was
easier.
Regards,
Mark.
> > > 2006/12/18, Stepan Mishura <st...@gmail.com>:
> > > > On 12/14/06, Leo Li wrote:
> > > > >
> > > > > Hi, all:
> > > > > When fixing the bug of Harmony-2678, I found Harmony fails to
> > get the
> > > > > AlgorithmParameters for the algorithm "OAEP" because of the
> > > > > signed.bcprov.jar used lacks a class called "
> > > > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But it
> > exist
> > > s
> > > > > in the latest release version of Bouncy Castle and I replace the
> > current
> > > > > used jar with bcprov-jdk15-134.jar and everything is OK.
> > > > > So shall we update the signed.bcprov.jar? If it is, I will give
> > a
> > > > > patch to the renew the make/depends.properties.
> > > >
> > > >
> > > > Hi Leo,
> > > >
> > > > I've applied your patch for upgrading version of Bounce Castle
> > provider
> > > > (from HARMONY-2678).
> > > >
> > > > Thanks,
> > > > Stepan.
> > > >
> >
> >
> >
>
> --
> Stepan Mishura
> Intel Enterprise Solutions Software Division
>
> ------=_Part_12072_8793811.1166451405277--
>
Re: [classlib][security] Whether to update the signed.bcprov.jar?
Posted by Stepan Mishura <st...@gmail.com>.
On 12/18/06, Mark Hindess wrote:
>
>
> On 18 December 2006 at 13:43, "Alexey Varlamov" wrote:
> > Stepan,
> >
> > I thougth we agreed to drop "signed" prefix. See also comment in the
> > depends.properties:
> > --------------------
> > # will the next person to update bcprov.jar please remove the "signed."
> > # prefix from the bcprov.jar property
> > bcprov.dir=${depends.jars}/bcprov-jdk15-134
> > bcprov.jar=${bcprov.dir}/signed.bcprov.jar
> > --------------------
>
> Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
> step that we needed a while back. I couldn't remove the prefix without
> making unnecessary work for developers so I left it to be removed next
> time developers had to fetch a new version.
Mark, sorry about that. I forgot to remove the prefix in the last moment.
BTW, what do you mean by saying "I couldn't remove the prefix without making
unnecessary work for developers"?
Thanks,
Stepan.
-Mark.
>
> > 2006/12/18, Stepan Mishura <st...@gmail.com>:
> > > On 12/14/06, Leo Li wrote:
> > > >
> > > > Hi, all:
> > > > When fixing the bug of Harmony-2678, I found Harmony fails to
> get the
> > > > AlgorithmParameters for the algorithm "OAEP" because of the
> > > > signed.bcprov.jar used lacks a class called "
> > > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But it
> exist
> > s
> > > > in the latest release version of Bouncy Castle and I replace the
> current
> > > > used jar with bcprov-jdk15-134.jar and everything is OK.
> > > > So shall we update the signed.bcprov.jar? If it is, I will give
> a
> > > > patch to the renew the make/depends.properties.
> > >
> > >
> > > Hi Leo,
> > >
> > > I've applied your patch for upgrading version of Bounce Castle
> provider
> > > (from HARMONY-2678).
> > >
> > > Thanks,
> > > Stepan.
> > >
>
>
>
--
Stepan Mishura
Intel Enterprise Solutions Software Division
Re: [classlib][security] Whether to update the signed.bcprov.jar?
Posted by Stepan Mishura <st...@gmail.com>.
On 12/18/06, Stepan Mishura wrote:
>
> On 12/18/06, Leo Li wrote:
> >
> > Hi, Mark:
> > OK, I have seen the comment.
> > I will try to add some modification to the script.
>
>
> Hi Leo,
>
> Thanks for a new patch. Your patch looks OK for me - all just will need
> to rename 'signed.bcprov.jar' to 'bcprov.jar' in
> depends/jars/bcprov-jdk15-134
> or
> rerun 'ant fetch-depends' (I guess CC will fail because of that)
>
> I'll wait for Mark comments - curious about "unnecessary work for
> developers". Just to be sure that I don't miss something.
>
>
Done at r488522.
Thanks,
Stepan.
Thanks,
> Stepan.
>
> On 12/18/06, Mark Hindess wrote:
> > >
> > >
> > > On 18 December 2006 at 13:43, "Alexey Varlamov" <
> > > alexey.v.varlamov@gmail.com> wrote:
> > > > Stepan,
> > > >
> > > > I thougth we agreed to drop "signed" prefix. See also comment in the
> >
> > > > depends.properties:
> > > > --------------------
> > > > # will the next person to update bcprov.jar please remove the
> > "signed."
> > > > # prefix from the bcprov.jar property
> > > > bcprov.dir=${depends.jars}/bcprov-jdk15-134
> > > > bcprov.jar=${bcprov.dir}/signed.bcprov.jar
> > > > --------------------
> > >
> > > Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
> > > step that we needed a while back. I couldn't remove the prefix
> > without
> > > making unnecessary work for developers so I left it to be removed next
> > > time developers had to fetch a new version.
> > >
> > > -Mark.
> > >
> > > > 2006/12/18, Stepan Mishura <st...@gmail.com>:
> > > > > On 12/14/06, Leo Li wrote:
> > > > > >
> > > > > > Hi, all:
> > > > > > When fixing the bug of Harmony-2678, I found Harmony fails
> > to
> > > get the
> > > > > > AlgorithmParameters for the algorithm "OAEP" because of the
> > > > > > signed.bcprov.jar used lacks a class called "
> > > > > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But
> > it
> > > exist
> > > > s
> > > > > > in the latest release version of Bouncy Castle and I replace the
> >
> > > current
> > > > > > used jar with bcprov-jdk15-134.jar and everything is OK.
> > > > > > So shall we update the signed.bcprov.jar? If it is, I will
> > give
> > > a
> > > > > > patch to the renew the make/depends.properties.
> > > > >
> > > > >
> > > > > Hi Leo,
> > > > >
> > > > > I've applied your patch for upgrading version of Bounce Castle
> > > provider
> > > > > (from HARMONY-2678).
> > > > >
> > > > > Thanks,
> > > > > Stepan.
> >
> > --
> > Stepan Mishura
> > Intel Enterprise Solutions Software Division
> >
>
Re: [classlib][security] Whether to update the signed.bcprov.jar?
Posted by Stepan Mishura <st...@gmail.com>.
On 12/18/06, Leo Li wrote:
>
> Hi, Mark:
> OK, I have seen the comment.
> I will try to add some modification to the script.
Hi Leo,
Thanks for a new patch. Your patch looks OK for me - all just will need
to rename 'signed.bcprov.jar' to 'bcprov.jar' in
depends/jars/bcprov-jdk15-134
or
rerun 'ant fetch-depends' (I guess CC will fail because of that)
I'll wait for Mark comments - curious about "unnecessary work for
developers". Just to be sure that I don't miss something.
Thanks,
Stepan.
On 12/18/06, Mark Hindess wrote:
> >
> >
> > On 18 December 2006 at 13:43, "Alexey Varlamov" <
> > alexey.v.varlamov@gmail.com> wrote:
> > > Stepan,
> > >
> > > I thougth we agreed to drop "signed" prefix. See also comment in the
> > > depends.properties:
> > > --------------------
> > > # will the next person to update bcprov.jar please remove the
> "signed."
> > > # prefix from the bcprov.jar property
> > > bcprov.dir=${depends.jars}/bcprov-jdk15-134
> > > bcprov.jar=${bcprov.dir}/signed.bcprov.jar
> > > --------------------
> >
> > Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
> > step that we needed a while back. I couldn't remove the prefix without
> > making unnecessary work for developers so I left it to be removed next
> > time developers had to fetch a new version.
> >
> > -Mark.
> >
> > > 2006/12/18, Stepan Mishura <st...@gmail.com>:
> > > > On 12/14/06, Leo Li wrote:
> > > > >
> > > > > Hi, all:
> > > > > When fixing the bug of Harmony-2678, I found Harmony fails to
> > get the
> > > > > AlgorithmParameters for the algorithm "OAEP" because of the
> > > > > signed.bcprov.jar used lacks a class called "
> > > > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But
> it
> > exist
> > > s
> > > > > in the latest release version of Bouncy Castle and I replace the
> > current
> > > > > used jar with bcprov-jdk15-134.jar and everything is OK.
> > > > > So shall we update the signed.bcprov.jar? If it is, I will
> give
> > a
> > > > > patch to the renew the make/depends.properties.
> > > >
> > > >
> > > > Hi Leo,
> > > >
> > > > I've applied your patch for upgrading version of Bounce Castle
> > provider
> > > > (from HARMONY-2678).
> > > >
> > > > Thanks,
> > > > Stepan.
> > > >
> > > > --
> > > > > Leo Li
> > > > > China Software Development Lab, IBM
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Stepan Mishura
> > > > Intel Enterprise Solutions Software Division
> > > >
> > > >
> > >
> >
> >
> >
>
>
> --
> Leo Li
> China Software Development Lab, IBM
>
>
--
Stepan Mishura
Intel Enterprise Solutions Software Division
Re: [classlib][security] Whether to update the signed.bcprov.jar?
Posted by Leo Li <li...@gmail.com>.
Hi, Mark:
OK, I have seen the comment.
I will try to add some modification to the script.
On 12/18/06, Mark Hindess <ma...@googlemail.com> wrote:
>
>
> On 18 December 2006 at 13:43, "Alexey Varlamov" <
> alexey.v.varlamov@gmail.com> wrote:
> > Stepan,
> >
> > I thougth we agreed to drop "signed" prefix. See also comment in the
> > depends.properties:
> > --------------------
> > # will the next person to update bcprov.jar please remove the "signed."
> > # prefix from the bcprov.jar property
> > bcprov.dir=${depends.jars}/bcprov-jdk15-134
> > bcprov.jar=${bcprov.dir}/signed.bcprov.jar
> > --------------------
>
> Indeed. The 'signed.' prefix was left when I removed the 'unsigning'
> step that we needed a while back. I couldn't remove the prefix without
> making unnecessary work for developers so I left it to be removed next
> time developers had to fetch a new version.
>
> -Mark.
>
> > 2006/12/18, Stepan Mishura <st...@gmail.com>:
> > > On 12/14/06, Leo Li wrote:
> > > >
> > > > Hi, all:
> > > > When fixing the bug of Harmony-2678, I found Harmony fails to
> get the
> > > > AlgorithmParameters for the algorithm "OAEP" because of the
> > > > signed.bcprov.jar used lacks a class called "
> > > > org.bouncycastle.jce.provider.JDKAlgorithmParameters$OAEP ". But it
> exist
> > s
> > > > in the latest release version of Bouncy Castle and I replace the
> current
> > > > used jar with bcprov-jdk15-134.jar and everything is OK.
> > > > So shall we update the signed.bcprov.jar? If it is, I will give
> a
> > > > patch to the renew the make/depends.properties.
> > >
> > >
> > > Hi Leo,
> > >
> > > I've applied your patch for upgrading version of Bounce Castle
> provider
> > > (from HARMONY-2678).
> > >
> > > Thanks,
> > > Stepan.
> > >
> > > --
> > > > Leo Li
> > > > China Software Development Lab, IBM
> > > >
> > > >
> > >
> > >
> > > --
> > > Stepan Mishura
> > > Intel Enterprise Solutions Software Division
> > >
> > >
> >
>
>
>
--
Leo Li
China Software Development Lab, IBM