You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2010/07/08 12:32:50 UTC

[jira] Created: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

TestRumenJobTraces fails in trunk
---------------------------------

                 Key: MAPREDUCE-1925
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: tools/rumen
    Affects Versions: 0.22.0
            Reporter: Amareshwari Sriramadasu
             Fix For: 0.22.0


TestRumenJobTraces failed with following error:
Error Message

the gold file contains more text at line 1 expected:<56> but was:<0>

Stacktrace

	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)

Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926081#action_12926081 ] 

Hudson commented on MAPREDUCE-1925:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
    

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889758#action_12889758 ] 

Ravi Gummadi commented on MAPREDUCE-1925:
-----------------------------------------

    *  Invert the order of closing the input stream and returning the the decompressor in PossiblyDecompressedInputStream. Rationale: CompressionInputStream.close() may still access the decompressor.

OK. Will do this.

    * Explicitly make the buffer size and mark limit consistent. E.g. "static final int BUFSIZE = 10000; BufferedInputStream bis = new BufferedInputStream(inputLogStream, BUFSIZE); bis.mark(BUFSIZE);"

I didn't get why these 2 should be same. As default BUFSIZE is 8K, we just need some number > 8k and the testcase is using 10000. Isn't this OK ? Any issues ? Just to be on the safer side, if you want it to be increased to a bigger value like 32K(from 10000), I can do so. Do you see any gain because of having these 2 same ?

    * Move this "Hadoop20JHParser parser = new Hadoop20JHParser(bis);" after bis.reset(). Rationale: in case in the future this constructor may read a few bytes from the stream.

This was already incorporated in my latest patch 1925.v1.1.patch.


> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Status: Open  (was: Patch Available)

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890786#action_12890786 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

One minor nit: Can we avoid involving InputDemuxer in getRewindableInputStream? It probably suffice to create a FSDataInputStream and create a RewindableInputStream on top of it. Other than that, the patch looks good.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Status: Patch Available  (was: Open)

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Attachment: 1925.v1.1.patch

Attaching new patch for current trunk. Updates the testcases refactored and made more readable.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891687#action_12891687 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

Patch looks good to me. +1.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886659#action_12886659 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

PossiblyDecompressedInputStream.close() seems to be wrong. it should close coreInputStream before returning back the decompressor.

The following is also problematic:
{code}

    BufferedInputStream bis = new BufferedInputStream(inputLogStream);
    bis.mark(10000);
    Hadoop20JHParser parser = new Hadoop20JHParser(bis);
{code}

The default buffer size is 8K, so mark a position with a read-ahead limit of 10000 characters could fail if the underlying stream does too much read ahead.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Status: Patch Available  (was: Open)

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887702#action_12887702 ] 

Ravi Gummadi commented on MAPREDUCE-1925:
-----------------------------------------

Problem is with the following line in the testcase:
{code}Hadoop20JHParser.canParse(inputLogStream));{code}
It should be reading from BuffuredInputStream 'bis' instead of inputLogStream --- sothat bis.reset() would work.
{code}Hadoop20JHParser.canParse(bis));{code}

With this change result.txt file contains events. But these events are more than that are there in the expected events file. The expected events file itself seems to be wrong and needs to be updated to have these events.
Investigating more why this bug is uncovered only now(after HADOOP-6835) only.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Attachment: 1925.v2.patch

Attaching new patch incorporating Hong's comments.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889953#action_12889953 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

bq. CodecPool.returnDecompressor() internally calls decompressor.reset(). Wouldn't this also potentially access the underlying I/O stream?

No, Decompressor.reset() clears its state so that it can be reused to decompress another stream of input. A bug in a similar nature is HADOOP-4195.

bq. I didn't get why these 2 should be same. As default BUFSIZE is 8K, we just need some number > 8k and the testcase is using 10000. Isn't this OK ? Any issues ? Just to be on the safer side, if you want it to be increased to a bigger value like 32K(from 10000), I can do so. Do you see any gain because of having these 2 same ?

That is fine too. I would even prefer to have the code to reflect the nature that the buffer size must be no less than the mark limit through something like: bis.mark(Math.min(BUFSIZE, 10000)).

bq. Can we modify the testcase to make use of RewindableInputStream? Rumen actually uses RewindableInputStream to take care of this mark/reset business.
That is also fine with me.

bq. This was already incorporated in my latest patch 1925.v1.1.patch.
Thanks!

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Status: Patch Available  (was: Open)

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Attachment: 1925.patch

Attaching patch fixing the testcase and the dependent gzipped data file.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889757#action_12889757 ] 

Amar Kamat commented on MAPREDUCE-1925:
---------------------------------------

bq. Invert the order of closing the input stream and returning the the decompressor in PossiblyDecompressedInputStream. 
_CodecPool.returnDecompressor()_ internally calls _decompressor.reset()_.  Wouldn't this also potentially access the underlying I/O stream?

bq. Explicitly make the buffer size and mark limit consistent.
Is this just for the testcase or for the Rumen framework code too?

bq. Move this "Hadoop20JHParser parser = new Hadoop20JHParser(bis);" after bis.reset().
Isn't this what Ravi has done? 
{code}
Hadoop20JHParser parser = null;
try {
...
..
bis.reset();
parser = new Hadoop20JHParser(bis);
...
..
}
{code}

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Status: Open  (was: Patch Available)

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888212#action_12888212 ] 

Amar Kamat commented on MAPREDUCE-1925:
---------------------------------------

Few comments
# The patch doesnt contain the changes to the {{v20-single-input-log-event-classes.text.gz}} file. 
# You can get rid of the {{inputLogStream}} variable to avoid future confusion
# You can make the resulting events list and the gold-standard list, in-memory. Instead of writing the test events into a file ({{result.txt}}) and then comparing the contents of 2 files ({{result.txt}} and {{v20-single-input-log-event-classes.text.gz}}) you can keep the contents of both the files in memory and get rid of {{result.txt}} and {{v20-single-input-log-event-classes.text.gz}}. The test will be faster and also easy to change in future.
# If you decide to do the above then there is no need of {{tempDir}} and {{rootTempDir}}.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889253#action_12889253 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

The patch looks good - the test case looks much cleaner now. 

Could you also accommodate a few minor issues I found?

- Invert the order of closing the input stream and returning the the decompressor in PossiblyDecompressedInputStream. Rationale: CompressionInputStream.close() may still access the decompressor.
- Explicitly make the buffer size and mark limit consistent. E.g. "static final int BUFSIZE = 10000; BufferedInputStream bis = new BufferedInputStream(inputLogStream, BUFSIZE); bis.mark(BUFSIZE);"
- Move this "Hadoop20JHParser parser = new Hadoop20JHParser(bis);" after bis.reset(). Rationale: in case in the future this constructor may read a few bytes from the stream.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886643#action_12886643 ] 

Amar Kamat commented on MAPREDUCE-1925:
---------------------------------------

Looked at if briefly and it seems that there is some issue with mark and reset on compressed files. {{TestRumenJobTraces.testHadoop20JHParser()}} uses {{PossiblyDecompressedInputStream}} for reading the compressed _v20-single-input-log.gz_ file. I commented out the code to do with reset and the test passed. For now one possible culprit is HADOOP-6835.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891552#action_12891552 ] 

Ravi Gummadi commented on MAPREDUCE-1925:
-----------------------------------------

Hudson seems to be not responding.
I ran ant test and test-patch myself.

All unit tests passed except the known failure of MAPREDUCE-1834.

ant test-patch gave:

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 5 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.


> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat reassigned MAPREDUCE-1925:
-------------------------------------

    Assignee: Ravi Gummadi

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889762#action_12889762 ] 

Amar Kamat commented on MAPREDUCE-1925:
---------------------------------------

{quote}
    *  Explicitly make the buffer size and mark limit consistent. E.g. "static final int BUFSIZE = 10000; BufferedInputStream bis = new BufferedInputStream(inputLogStream, BUFSIZE); bis.mark(BUFSIZE);"

I didn't get why these 2 should be same.
{quote}
Can we modify the testcase to make use of {{RewindableInputStream}}? Rumen actually uses {{RewindableInputStream}} to take care of this _mark/reset_ business.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1925:
-------------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

+1

I committed this. Thanks, Ravi!

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888249#action_12888249 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

Git diff --text will add binary diff to the patch.





> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888257#action_12888257 ] 

Ravi Gummadi commented on MAPREDUCE-1925:
-----------------------------------------

Thanks Hong.
Will upload new patch which removes that .gz file and the testcase itself contains the expected list of events as array of Strings.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Attachment: 1925.v2.1.patch

Attaching new patch removing the dependency of InputDemuxer in getRewindableInputStream().

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch, 1925.v2.1.patch, 1925.v2.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Gummadi updated MAPREDUCE-1925:
------------------------------------

    Attachment: 1925.v1.patch

Attaching new patch incorporating review comments.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888209#action_12888209 ] 

Ravi Gummadi commented on MAPREDUCE-1925:
-----------------------------------------

'git diff' couldn't get the changes to the gzipped file in my patch attached.
I will remove the whole file and will have the expected output in an array in the test case itself --- as suggested by Amar offline.

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1925) TestRumenJobTraces fails in trunk

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886661#action_12886661 ] 

Hong Tang commented on MAPREDUCE-1925:
--------------------------------------

However, this should not be a problem because otherwise bis.reset() should throw IOException. 

Also, the following line is better to be moved after bis.reset():

{code}
    Hadoop20JHParser parser = new Hadoop20JHParser(bis);
{code}

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> 	at org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.