You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2013/03/17 21:14:14 UTC

svn commit: r1457549 - in /lucene/dev/trunk/lucene/core/src: java/org/apache/lucene/util/fst/Builder.java java/org/apache/lucene/util/fst/FST.java java/org/apache/lucene/util/fst/TODO test/org/apache/lucene/util/fst/TestFSTs.java

Author: mikemccand
Date: Sun Mar 17 20:14:14 2013
New Revision: 1457549

URL: http://svn.apache.org/r1457549
Log:
disperse the old FST TODO file

Removed:
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/TODO
Modified:
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/Builder.java
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/FST.java
    lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java

Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/Builder.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/Builder.java?rev=1457549&r1=1457548&r2=1457549&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/Builder.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/Builder.java Sun Mar 17 20:14:14 2013
@@ -25,6 +25,9 @@ import org.apache.lucene.util.RamUsageEs
 import org.apache.lucene.util.fst.FST.INPUT_TYPE; // javadoc
 import org.apache.lucene.util.packed.PackedInts;
 
+// TODO: could we somehow stream an FST to disk while we
+// build it?
+
 /**
  * Builds a minimal FST (maps an IntsRef term to an arbitrary
  * output) from pre-sorted terms with outputs.  The FST

Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/FST.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/FST.java?rev=1457549&r1=1457548&r2=1457549&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/FST.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/fst/FST.java Sun Mar 17 20:14:14 2013
@@ -1093,6 +1093,9 @@ public final class FST<T> {
     return arc;
   }
 
+  // TODO: could we somehow [partially] tableize arc lookups
+  // look automaton?
+
   /** Finds an arc leaving the incoming arc, replacing the arc in place.
    *  This returns null if the arc was not found, else the incoming arc. */
   public Arc<T> findTargetArc(int labelToMatch, Arc<T> follow, Arc<T> arc, BytesReader in) throws IOException {

Modified: lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java?rev=1457549&r1=1457548&r2=1457549&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java (original)
+++ lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java Sun Mar 17 20:14:14 2013
@@ -587,6 +587,12 @@ public class TestFSTs extends LuceneTest
     }
   }
 
+  // TODO: try experiment: reverse terms before
+  // compressing -- how much smaller?
+
+  // TODO: can FST be used to index all internal substrings,
+  // mapping to term?
+
   // java -cp ../build/codecs/classes/java:../test-framework/lib/randomizedtesting-runner-2.0.8.jar:../build/core/classes/test:../build/core/classes/test-framework:../build/core/classes/java:../build/test-framework/classes/java:../test-framework/lib/junit-4.10.jar org.apache.lucene.util.fst.TestFSTs /xold/tmp/allTerms3.txt out
   public static void main(String[] args) throws IOException {
     int prune = 0;