[GitHub] [lucene] original-brownbear commented on pull request #12270: Don't generate stacktrace in CollectionTerminatedException

["original-brownbear (via GitHub)" <gi...@apache.org>]

original-brownbear commented on PR #12270:
URL: https://github.com/apache/lucene/pull/12270#issuecomment-1538083118

   > e.g. a stacktrace for it should never be requested.
   
   I'm a little hesitant to add an assertion for this to be honest, not sure what the effects would be, I've never seen that asserted. 
   But I do wonder, maybe we should go one step further here and just make this exception a singleton? That saves a couple more cycles and makes it ever clearer to people that they probably shouldn't use this for anything but their intended purpose?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org