[GitHub] [geode] aditya87 opened pull request #2794: [GEODE-5971] Refactor offline disk store commands to extend SingleGfshCommand base type

["aditya87 (GitHub)" <gi...@apache.org>]

Signed-off-by: Peter Tran <pt...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2794 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2794: [GEODE-5971] Refactor offline disk store commands to extend SingleGfshCommand base type

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

The test is really an integration test. Tests that use `ServerStarterRule` (or `LocatorStarterRule`) don't fork separate JVMs but start a cache within the test JVM itself - this is essentially the definition of an integration test as it applies to the codebase. `ClusterStarterRule`, on the other hand, does fork separate JVMs and thus all tests that use that rule should be classified as DUnit tests.

[ Full content available at: https://github.com/apache/geode/pull/2794 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #2794: [GEODE-5971] Refactor offline disk store commands to extend SingleGfshCommand base type

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2794 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2794: [GEODE-5971] Refactor offline disk store commands to extend SingleGfshCommand base type

["jinmeiliao (GitHub)" <gi...@apache.org>]

Not sure if this would make sense. these are offline commands. SingleGfshCommand is designed for commands that would change cluster configuration. I would like to see all offline commands stay as GfshCommand or InternalGfshCommand..

[ Full content available at: https://github.com/apache/geode/pull/2794 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2794: [GEODE-5971] Refactor offline disk store commands to extend SingleGfshCommand base type

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

After some offline conversation, the ultimate goal would be to move everything to `SingleGfshCommand`.

[ Full content available at: https://github.com/apache/geode/pull/2794 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org