You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/05 18:04:02 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13410: [BEAM-11327] Replace Charset.defaultCharset() with StandardCharsets.UTF_8

TheNeuralBit commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r552101064



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -69,6 +69,9 @@
     private int carryOverBytes;
     private byte[] carryOverByteArray;
 
+    @SuppressWarnings({
+      "unchecked" // [BEAM-11327] Replace Charset.defaultCharset() with StandardCharsets.UTF_8

Review comment:
       Shouldn't this be ForbidDefaultCharset?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org