You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/28 13:48:14 UTC
[GitHub] [superset] kgabryje opened a new pull request #19394: Feat/dataset panel UI
kgabryje opened a new pull request #19394:
URL: https://github.com/apache/superset/pull/19394
### SUMMARY
This PR implements several UI changes in Explore's dataset panel.
List of changes:
- change color of background to white
- separate each column/metric label with vertical margins
- add dots icon to column/metric labels to indicate they're draggable
- move certification icon to the right side of the label
- Change font size of column/metric section labels to 12 and remove separation line
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="647" alt="image" src="https://user-images.githubusercontent.com/15073128/160411310-b9851cf1-0b02-4ce1-90aa-5f619117a343.png">
### TESTING INSTRUCTIONS
Verify that everything works like before
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC @kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837181690
##########
File path: superset-frontend/src/components/Icons/index.tsx
##########
@@ -65,6 +65,7 @@ const IconFileNames = [
'dataset_virtual',
'download',
'drag',
+ 'drag_icon',
Review comment:
Nahh, I just forgot to delete that (added for test purposes). Good eye as always π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1081881977
# [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19394](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5653f8) into [master](https://codecov.io/gh/apache/superset/commit/45c28c8046c56d4ebe1dfaf0235783fe864ae75f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45c28c8) will **decrease** coverage by `0.18%`.
> The diff coverage is `86.44%`.
> :exclamation: Current head d5653f8 differs from pull request most recent head 8a797f5. Consider uploading reports for the commit 8a797f5 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19394 +/- ##
==========================================
- Coverage 66.67% 66.48% -0.19%
==========================================
Files 1676 1670 -6
Lines 64714 63968 -746
Branches 6506 6510 +4
==========================================
- Hits 43150 42532 -618
+ Misses 19878 19747 -131
- Partials 1686 1689 +3
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <83.33%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `80.00% <ΓΈ> (ΓΈ)` | |
| [...d/packages/superset-ui-chart-controls/src/index.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2luZGV4LnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...-chart-controls/src/sections/advancedAnalytics.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2FkdmFuY2VkQW5hbHl0aWNzLnRzeA==) | `33.33% <ΓΈ> (ΓΈ)` | |
| [...omponents/ColumnConfigControl/ColumnConfigItem.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9jb21wb25lbnRzL0NvbHVtbkNvbmZpZ0NvbnRyb2wvQ29sdW1uQ29uZmlnSXRlbS50c3g=) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...uperset-ui-core/src/query/types/AnnotationLayer.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvQW5ub3RhdGlvbkxheWVyLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [.../plugins/plugin-chart-echarts/src/BoxPlot/types.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQm94UGxvdC90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...d/plugins/plugin-chart-echarts/src/Funnel/types.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvRnVubmVsL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...nd/plugins/plugin-chart-echarts/src/Gauge/types.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR2F1Z2UvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...tend/plugins/plugin-chart-echarts/src/Pie/types.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvUGllL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...ugins/plugin-chart-echarts/src/Timeseries/types.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90eXBlcy50cw==) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [45c28c8...8a797f5](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1081881977
# [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19394](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df994fc) into [master](https://codecov.io/gh/apache/superset/commit/a619cb4ea98342a2fdf7f77587d8aa078c7dccef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a619cb4) will **increase** coverage by `0.00%`.
> The diff coverage is `93.54%`.
> :exclamation: Current head df994fc differs from pull request most recent head cdac852. Consider uploading reports for the commit cdac852 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19394 +/- ##
=======================================
Coverage 66.48% 66.49%
=======================================
Files 1670 1670
Lines 63968 63971 +3
Branches 6512 6510 -2
=======================================
+ Hits 42531 42535 +4
+ Misses 19748 19747 -1
Partials 1689 1689
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.33% <93.54%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `80.00% <ΓΈ> (ΓΈ)` | |
| [...d/packages/superset-ui-chart-controls/src/index.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2luZGV4LnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...omponents/ColumnConfigControl/ColumnConfigItem.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9jb21wb25lbnRzL0NvbHVtbkNvbmZpZ0NvbnRyb2wvQ29sdW1uQ29uZmlnSXRlbS50c3g=) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `71.87% <ΓΈ> (ΓΈ)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `85.71% <50.00%> (+1.09%)` | :arrow_up: |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `69.23% <80.00%> (-0.13%)` | :arrow_down: |
| [...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsL0NvbHVtblR5cGVMYWJlbC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `94.73% <100.00%> (+0.29%)` | :arrow_up: |
| [...ontend/src/dashboard/components/dnd/DragHandle.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnSGFuZGxlLnRzeA==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a619cb4...cdac852](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #19394:
URL: https://github.com/apache/superset/pull/19394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837436512
##########
File path: superset-frontend/src/dashboard/components/dnd/DragHandle.tsx
##########
@@ -17,33 +17,35 @@
* under the License.
*/
import React, { LegacyRef } from 'react';
-import cx from 'classnames';
+import { css, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
interface DragHandleProps {
position: 'left' | 'top';
- innerRef: LegacyRef<HTMLDivElement> | undefined;
- dotCount: number;
+ innerRef?: LegacyRef<HTMLDivElement> | undefined;
}
+const DragHandleContainer = styled.div<{ position: 'left' | 'top' }>`
+ ${({ theme, position }) => css`
+ margin-bottom: ${theme.gridUnit}px !important;
Review comment:
```suggestion
height: 21px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837391655
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -97,26 +101,55 @@ const DatasourceContainer = styled.div`
`;
const LabelWrapper = styled.div`
- overflow: hidden;
- text-overflow: ellipsis;
+ ${({ theme }) => css`
+ overflow: hidden;
+ text-overflow: ellipsis;
+ font-size: ${theme.typography.sizes.s}px;
+ background-color: ${theme.colors.grayscale.light4};
+ margin: ${theme.gridUnit * 2}px 0;
+ border-radius: 4px;
Review comment:
```suggestion
border-radius: ${theme.gridUnit}px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1081624185
> Can we make the draggable image respect the border-radius and width of the original component
Good point, done!
<img width="742" alt="image" src="https://user-images.githubusercontent.com/15073128/160577068-b8621c66-e7c5-42dd-8bd5-4d542a2b2999.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1081881977
# [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19394](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a797f5) into [master](https://codecov.io/gh/apache/superset/commit/45c28c8046c56d4ebe1dfaf0235783fe864ae75f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45c28c8) will **increase** coverage by `0.00%`.
> The diff coverage is `93.54%`.
```diff
@@ Coverage Diff @@
## master #19394 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 1676 1676
Lines 64714 64726 +12
Branches 6506 6510 +4
=======================================
+ Hits 43150 43159 +9
Misses 19878 19878
- Partials 1686 1689 +3
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.33% <93.54%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `80.00% <ΓΈ> (ΓΈ)` | |
| [...d/packages/superset-ui-chart-controls/src/index.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2luZGV4LnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...omponents/ColumnConfigControl/ColumnConfigItem.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9jb21wb25lbnRzL0NvbHVtbkNvbmZpZ0NvbnRyb2wvQ29sdW1uQ29uZmlnSXRlbS50c3g=) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `71.87% <ΓΈ> (ΓΈ)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `85.71% <50.00%> (+1.09%)` | :arrow_up: |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `69.23% <80.00%> (-0.13%)` | :arrow_down: |
| [...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsL0NvbHVtblR5cGVMYWJlbC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `94.73% <100.00%> (+0.29%)` | :arrow_up: |
| [...ontend/src/dashboard/components/dnd/DragHandle.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnSGFuZGxlLnRzeA==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [45c28c8...8a797f5](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1080972243
I love the changes! Really improved the user experience. cc @kasiazjc
I have one suggestion that may be tackled in a separate PR if you wish. Can we make the draggable image respect the border-radius and width of the original component? If we do that, when the user is dropping, it will fit exactly in the droppable area π€©
https://user-images.githubusercontent.com/70410625/160459019-b4671a3c-56d7-449c-8da2-e218ec7ebd86.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r836746217
##########
File path: superset-frontend/src/components/Icons/index.tsx
##########
@@ -65,6 +65,7 @@ const IconFileNames = [
'dataset_virtual',
'download',
'drag',
+ 'drag_icon',
Review comment:
I'm not sure `drag_icon` is the best name, all declarations here are icons. What's the difference between the drag icons? Maybe we can come up with a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837480017
##########
File path: superset-frontend/src/dashboard/components/dnd/DragHandle.tsx
##########
@@ -17,33 +17,35 @@
* under the License.
*/
import React, { LegacyRef } from 'react';
-import cx from 'classnames';
+import { css, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
interface DragHandleProps {
position: 'left' | 'top';
- innerRef: LegacyRef<HTMLDivElement> | undefined;
- dotCount: number;
+ innerRef?: LegacyRef<HTMLDivElement> | undefined;
}
+const DragHandleContainer = styled.div<{ position: 'left' | 'top' }>`
+ ${({ theme, position }) => css`
+ margin-bottom: ${theme.gridUnit}px !important;
Review comment:
π
Looks good after changing to height: 20, thanks for the tip
<img width="613" alt="image" src="https://user-images.githubusercontent.com/15073128/160622851-00e092c7-d313-49f3-93aa-dbf1387a4483.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837469568
##########
File path: superset-frontend/src/dashboard/components/dnd/DragHandle.tsx
##########
@@ -17,33 +17,35 @@
* under the License.
*/
import React, { LegacyRef } from 'react';
-import cx from 'classnames';
+import { css, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
interface DragHandleProps {
position: 'left' | 'top';
- innerRef: LegacyRef<HTMLDivElement> | undefined;
- dotCount: number;
+ innerRef?: LegacyRef<HTMLDivElement> | undefined;
}
+const DragHandleContainer = styled.div<{ position: 'left' | 'top' }>`
+ ${({ theme, position }) => css`
+ margin-bottom: ${theme.gridUnit}px !important;
Review comment:
I'm reluctant to use a height that's not relative to gridUnit. Why do you think that's better than using margin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837471893
##########
File path: superset-frontend/src/dashboard/components/dnd/DragHandle.tsx
##########
@@ -17,33 +17,35 @@
* under the License.
*/
import React, { LegacyRef } from 'react';
-import cx from 'classnames';
+import { css, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
interface DragHandleProps {
position: 'left' | 'top';
- innerRef: LegacyRef<HTMLDivElement> | undefined;
- dotCount: number;
+ innerRef?: LegacyRef<HTMLDivElement> | undefined;
}
+const DragHandleContainer = styled.div<{ position: 'left' | 'top' }>`
+ ${({ theme, position }) => css`
+ margin-bottom: ${theme.gridUnit}px !important;
Review comment:
You can use 20px if you want. It's not perceivable. The problem is not the margin but `!important`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1081881977
# [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19394](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a797f5) into [master](https://codecov.io/gh/apache/superset/commit/a619cb4ea98342a2fdf7f77587d8aa078c7dccef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a619cb4) will **increase** coverage by `14.49%`.
> The diff coverage is `93.54%`.
> :exclamation: Current head 8a797f5 differs from pull request most recent head cdac852. Consider uploading reports for the commit cdac852 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19394 +/- ##
===========================================
+ Coverage 52.18% 66.67% +14.49%
===========================================
Files 1666 1676 +10
Lines 63813 64726 +913
Branches 6512 6510 -2
===========================================
+ Hits 33302 43159 +9857
+ Misses 28822 19878 -8944
Partials 1689 1689
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.33% <93.54%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `80.00% <ΓΈ> (ΓΈ)` | |
| [...d/packages/superset-ui-chart-controls/src/index.ts](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2luZGV4LnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...omponents/ColumnConfigControl/ColumnConfigItem.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9jb21wb25lbnRzL0NvbHVtbkNvbmZpZ0NvbnRyb2wvQ29sdW1uQ29uZmlnSXRlbS50c3g=) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `71.87% <ΓΈ> (ΓΈ)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `85.71% <50.00%> (+1.09%)` | :arrow_up: |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `69.23% <80.00%> (-0.13%)` | :arrow_down: |
| [...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsL0NvbHVtblR5cGVMYWJlbC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `94.73% <100.00%> (+0.29%)` | :arrow_up: |
| [...ontend/src/dashboard/components/dnd/DragHandle.tsx](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnSGFuZGxlLnRzeA==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
| ... and [335 more](https://codecov.io/gh/apache/superset/pull/19394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a619cb4...cdac852](https://codecov.io/gh/apache/superset/pull/19394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837397650
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -97,26 +101,55 @@ const DatasourceContainer = styled.div`
`;
const LabelWrapper = styled.div`
- overflow: hidden;
- text-overflow: ellipsis;
+ ${({ theme }) => css`
+ overflow: hidden;
+ text-overflow: ellipsis;
+ font-size: ${theme.typography.sizes.s}px;
+ background-color: ${theme.colors.grayscale.light4};
+ margin: ${theme.gridUnit * 2}px 0;
+ border-radius: 4px;
Review comment:
I don't think that is related to gridUnit. Supposedly, if we created a theme where distances between components are bigger, that doesn't mean we want the corners to be more rounded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #19394:
URL: https://github.com/apache/superset/pull/19394#issuecomment-1080972243
I loved the changes! Really improved the user experience. cc @kasiazjc
I have one suggestion that may be tackled in a separate PR if you wish. Can we make the draggable image respect the border-radius and width of the original component? If we do that, when the user is dropping, it will fit exactly in the droppable area π€©
https://user-images.githubusercontent.com/70410625/160459019-b4671a3c-56d7-449c-8da2-e218ec7ebd86.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837392545
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -273,13 +302,13 @@ export default function DataSourcePanel({
/>
<div className="field-selections">
<Collapse
- bordered
+ // bordered
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org