[jira] [Comment Edited] (SPARK-22331) Make MLlib string params case-insensitive

["Weichen Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-22331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216224#comment-16216224 ] 

Weichen Xu edited comment on SPARK-22331 at 10/24/17 2:19 PM:
--------------------------------------------------------------

OK, it seems not breaking current code in spark, but it is possible to influence user extension code. e.g., some user create his own `evaluator` class and in `metricName` param he use `ParamValidators.inArray(Array("aa", "AA"))` as allowedParams.But `Param` is develop api so it also doesn't matter.
OK I agree to make this change, if we do not find it break something.


was (Author: weichenxu123):
OK, it seems not breaking current code in spark, but it is possible to influence user extension code. e.g., some user create his own `evaluator` class and in `metricName` param he use `ParamValidators.inArray(Array("aa", "AA"))` as allowedParams. 

> Make MLlib string params case-insensitive
> -----------------------------------------
>
>                 Key: SPARK-22331
>                 URL: https://issues.apache.org/jira/browse/SPARK-22331
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>    Affects Versions: 2.2.0
>            Reporter: yuhao yang
>            Priority: Minor
>
> Some String params in ML are still case-sensitive, as they are checked by ParamValidators.inArray.
> For consistency in user experience, there should be some general guideline in whether String params in Spark MLlib are case-insensitive or not. 
> I'm leaning towards making all String params case-insensitive where possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org