You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/11 03:07:12 UTC

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6063: feat: supports to logging apisix_latency and upstream_latency.

zhendongcmss commented on a change in pull request #6063:
URL: https://github.com/apache/apisix/pull/6063#discussion_r781726288



##########
File path: apisix/utils/log-util.lua
##########
@@ -120,7 +122,9 @@ local function get_full_log(ngx, conf)
         consumer = consumer,
         client_ip = core.request.get_remote_client_ip(ngx.ctx.api_ctx),
         start_time = ngx.req.start_time() * 1000,
-        latency = (ngx_now() - ngx.req.start_time()) * 1000
+        latency = latency,
+        upstream_latency = upstream_latency,
+        apisix_latency = apisix_latency

Review comment:
       I think use `apisix_latency` is confused, refer another discussment https://github.com/apache/apisix/issues/6029.
   The `apisix_latenct` includes client sending data via network, not apisix exclusive. From my experience, it is large when tranfer big file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org