You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by chaitali <ch...@freestoneinfotech.com> on 2020/05/21 09:48:53 UTC

Re: Review Request 72531: ATLAS-3551 : Atlas unable to import entities if an HBase column family is deleted

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72531/
-----------------------------------------------------------

(Updated May 21, 2020, 9:48 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3551
    https://issues.apache.org/jira/browse/ATLAS-3551


Repository: atlas


Description
-------

When a HbaseColumnFamily was deleted attribute "table" was assigned null due to a check in EntityGraphretriever for legacyattribute where if (table)attribute Entity status is ACTIVE and relationship status is DELETED then the attribute was assigned null.
Hence this patch fix will it.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 757fcb116 
  repository/src/test/java/org/apache/atlas/repository/impexp/DeletedEntityReferenceTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/TestLoadModelUtils.java f17538673 


Diff: https://reviews.apache.org/r/72531/diff/3/


Testing (updated)
-------

Added testcases.
Basic testing done :

1.Table Entity-DELETED	Relationship-DELETED	Column Entity-DELETED (Column entity will contain attribute table)
2.Table Entity-ACTIVE	Relationship-DELETED	Column Entity-ACTIVE  (Column entity will Not contain attribute table)
3.Table Entity-DELETED	Relationship-DELETED	Column Entity-DELETED (Column entity will contain attribute table)
4.DB-ACTIVE	            RELATIONSHIP-DELETED    TABLE-ACTIVE          (Table entity will Not contain attribute db)
5.DB-ACTIVE	            RELATIONSHIP-ACTIVE	    TABLE-ACTIVE          (Table entity will contain attribute db)


Thanks,

chaitali