You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/02/28 05:25:34 UTC
Review Request 18608: Fix incorrect stderr to stdout pipe routing in
configuration phase.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18608/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
The configuration-phase incorrectly created a file named "1" as there was some pipe routing done by 2>1 and not 2>&1 as intended.
Diffs
-----
configure.ac 10bcf09
Diff: https://reviews.apache.org/r/18608/diff/
Testing
-------
bootstrap, configure, make check
Thanks,
Till Toenshoff
Re: Review Request 18608: Fix incorrect stderr to stdout pipe routing in
configuration phase.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18608/#review35846
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 27, 2014, 8:25 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18608/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 8:25 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The configuration-phase incorrectly created a file named "1" as there was some pipe routing done by 2>1 and not 2>&1 as intended.
>
>
> Diffs
> -----
>
> configure.ac 10bcf09
>
> Diff: https://reviews.apache.org/r/18608/diff/
>
>
> Testing
> -------
>
> bootstrap, configure, make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18608: Fix incorrect stderr to stdout pipe routing in
configuration phase.
Posted by Till Toenshoff <to...@me.com>.
> On Feb. 28, 2014, 4:43 a.m., Vinod Kone wrote:
> > configure.ac, line 527
> > <https://reviews.apache.org/r/18608/diff/1/?file=506732#file506732line527>
> >
> > OMG this baffled me for so long! Thank you!
> >
> >
Well, it was me who introduced this bug in the first place... SORRY!
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18608/#review35761
-----------------------------------------------------------
On Feb. 28, 2014, 4:25 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18608/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 4:25 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The configuration-phase incorrectly created a file named "1" as there was some pipe routing done by 2>1 and not 2>&1 as intended.
>
>
> Diffs
> -----
>
> configure.ac 10bcf09
>
> Diff: https://reviews.apache.org/r/18608/diff/
>
>
> Testing
> -------
>
> bootstrap, configure, make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18608: Fix incorrect stderr to stdout pipe routing in
configuration phase.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18608/#review35761
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/18608/#comment66499>
OMG this baffled me for so long! Thank you!
- Vinod Kone
On Feb. 28, 2014, 4:25 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18608/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 4:25 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The configuration-phase incorrectly created a file named "1" as there was some pipe routing done by 2>1 and not 2>&1 as intended.
>
>
> Diffs
> -----
>
> configure.ac 10bcf09
>
> Diff: https://reviews.apache.org/r/18608/diff/
>
>
> Testing
> -------
>
> bootstrap, configure, make check
>
>
> Thanks,
>
> Till Toenshoff
>
>