[jira] [Commented] (AMBARI-18471) Refactor yarn() function in YARN service. Part 1.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-18471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525616#comment-15525616 ] 

Hadoop QA commented on AMBARI-18471:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12830468/AMBARI-18471.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8715//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8715//console

This message is automatically generated.

> Refactor yarn() function in YARN service. Part 1.
> -------------------------------------------------
>
>                 Key: AMBARI-18471
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18471
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Andrew Onischuk
>            Assignee: Andrew Onischuk
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-18471.patch
>
>
> Fix the most obvious points of the main jira:
> 1\. Refactor this code to have individual functions for components.  
> 2\. Remove conditions for xmlConfigs, where they are not needed
> The other part of the jira requires more discussion, it probably will be
> easier to do once we have a cleaner look on the code and shrink the scope of
> the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)