[GitHub] [tvm] areusch commented on a change in pull request #7988: [AOT] Remove lookup parameter function in AOT

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #7988:
URL: https://github.com/apache/tvm/pull/7988#discussion_r631355963



##########
File path: src/target/source/codegen_c.cc
##########
@@ -662,6 +662,11 @@ void CodeGenC::VisitExpr_(const CallNode* op, std::ostream& os) {  // NOLINT(*)
       os << " != ";
       this->PrintExpr(op->args[0], os);
       os << ")";
+    } else if (op->op.same_as(builtin::lookup_param())) {
+      ICHECK_EQ(op->args.size(), 1);
+      const StringImmNode* str = op->args[0].as<StringImmNode>();
+      ICHECK(str != nullptr);
+      os << "__tvm_param__" << str->value;

Review comment:
       along the lines of @mjs comment that `__` are reserved for c++ compiler naming, shall we rename this to simply `tvm_param_`? and, we should consider naming this after the model as well. finally, it would be great to retain `tvm_param_prefix` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org