You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/14 03:14:21 UTC

[GitHub] [spark] panbingkun opened a new pull request, #38246: [SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite

panbingkun opened a new pull request, #38246:
URL: https://github.com/apache/spark/pull/38246

   ### What changes were proposed in this pull request?
   This PR aims to replace 'intercept' with 'Check error classes' in CreateNamespaceParserSuite.
   
   ### Why are the changes needed?
   The changes improve the error framework.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Pass GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #38246: [SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38246:
URL: https://github.com/apache/spark/pull/38246#issuecomment-1278482192

   +1, LGTM. Merging to master.
   I ran the modified tests locally:
   ```
   $ build/sbt "test:testOnly *CreateNamespaceParserSuite"
   [info] CreateNamespaceParserSuite:
   [info] - create namespace - backward compatibility with DATABASE/DBPROPERTIES (1 second, 165 milliseconds)
   [info] - create namespace - check duplicates (425 milliseconds)
   [info] - create namespace - property values must be set (4 milliseconds)
   [info] - create namespace - either PROPERTIES or DBPROPERTIES is allowed (4 milliseconds)
   [info] - create namespace - support for other types in PROPERTIES (5 milliseconds)
   ...
   [info] All tests passed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #38246: [SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite

Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #38246:
URL: https://github.com/apache/spark/pull/38246#issuecomment-1278417319

   cc @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #38246: [SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38246: [SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite
URL: https://github.com/apache/spark/pull/38246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org