You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/22 15:13:50 UTC

[GitHub] [superset] zhaoyongjie opened a new pull request #17851: fix(deckgl): deckgl unable to load map

zhaoyongjie opened a new pull request #17851:
URL: https://github.com/apache/superset/pull/17851


   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774300957



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       `mapbox-gl` is a dependency from the `react-map-gl`. The root cause for this issue is that `mapbox-gl` version is incompatible between `legacy-plugin-chart-map-box` and `legacy-preset-chart-deckgl`. 
   
   When we removed `mapbox-gl` in both packages, npm will auto-resolve the conflict. If the user installs those packages as standalone, `mapbox-gl` will install by default.
   
   #### `legacy-plugin-chart-map-box` dependencies tree
   ```
   (superset) yongjie.zhao@:superset-frontend$ npm ls --depth 1 | grep -A 30 'map-box'
   ....
   ....
   ├─┬ @superset-ui/legacy-plugin-chart-map-box@0.18.25 -> ./plugins/legacy-plugin-chart-map-box
   │ ├── @superset-ui/chart-controls@0.18.25 deduped -> ./packages/superset-ui-chart-controls
   │ ├── @superset-ui/core@0.18.25 deduped -> ./packages/superset-ui-core
   │ ├── prop-types@15.7.2 deduped
   │ ├─┬ react-map-gl@4.1.16
   │ │ ├── @babel/runtime@7.15.4 deduped
   │ │ ├── mapbox-gl@0.54.1
   │ │ ├── mjolnir.js@2.5.0
   │ │ ├── prop-types@15.7.2 deduped
   │ │ ├── react-virtualized-auto-sizer@1.0.2 deduped
   │ │ ├── react@16.14.0 deduped invalid: "^15.5.4" from node_modules/omnibar
   │ │ └── viewport-mercator-project@6.2.3 deduped
   │ ├── react@16.14.0 deduped
   │ ├─┬ supercluster@4.1.1
   │ │ └── kdbush@2.0.1
   │ └─┬ viewport-mercator-project@6.2.3
   │   ├── @babel/runtime@7.15.4 deduped
   │   └── gl-matrix@3.3.0
   ....
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774325925



##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/package.json
##########
@@ -32,12 +32,10 @@
     "deck.gl": "8.5.2",
     "jquery": "^3.4.1",
     "lodash": "^4.17.15",
-    "mapbox-gl": "^2.4.0",

Review comment:
       the `mapbox-gl` come from `react-map-gl`, so we didn't need to add this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774300957



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       `mapbox-gl` is a dependency from the `react-map-gl`, and `mapbox-gl` is a dependency for `deckgl`. The root cause for this issue is that `mapbox-gl` version is incompatible in `legacy-plugin-chart-map-box` and `legacy-preset-chart-deckgl`. 
   
   When we removed `mapbox-gl` in both packages, npm will auto-resolve the conflict. If the user installs those packages as standalone, `mapbox-gl` will install by default.
   
   #### `legacy-plugin-chart-map-box` dependencies tree
   ```
   (superset) yongjie.zhao@:superset-frontend$ npm ls --depth 1 | grep -A 30 'map-box'
   ....
   ....
   ├─┬ @superset-ui/legacy-plugin-chart-map-box@0.18.25 -> ./plugins/legacy-plugin-chart-map-box
   │ ├── @superset-ui/chart-controls@0.18.25 deduped -> ./packages/superset-ui-chart-controls
   │ ├── @superset-ui/core@0.18.25 deduped -> ./packages/superset-ui-core
   │ ├── prop-types@15.7.2 deduped
   │ ├─┬ react-map-gl@4.1.16
   │ │ ├── @babel/runtime@7.15.4 deduped
   │ │ ├── mapbox-gl@0.54.1
   │ │ ├── mjolnir.js@2.5.0
   │ │ ├── prop-types@15.7.2 deduped
   │ │ ├── react-virtualized-auto-sizer@1.0.2 deduped
   │ │ ├── react@16.14.0 deduped invalid: "^15.5.4" from node_modules/omnibar
   │ │ └── viewport-mercator-project@6.2.3 deduped
   │ ├── react@16.14.0 deduped
   │ ├─┬ supercluster@4.1.1
   │ │ └── kdbush@2.0.1
   │ └─┬ viewport-mercator-project@6.2.3
   │   ├── @babel/runtime@7.15.4 deduped
   │   └── gl-matrix@3.3.0
   ....
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17851:
URL: https://github.com/apache/superset/pull/17851#issuecomment-999692137


   # [Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17851](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e91f70b) into [master](https://codecov.io/gh/apache/superset/commit/9840fbf49be2668553e68aded3d77988077b8565?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9840fbf) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17851/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #17851      +/-   ##
   ==========================================
   - Coverage   66.98%   66.98%   -0.01%     
   ==========================================
     Files        1609     1609              
     Lines       64865    64879      +14     
     Branches     6863     6866       +3     
   ==========================================
   + Hits        43448    43457       +9     
   - Misses      19553    19556       +3     
   - Partials     1864     1866       +2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `53.77% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvRGVja0dMQ29udGFpbmVyLmpzeA==) | `0.00% <ø> (ø)` | |
   | [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `71.79% <0.00%> (-1.29%)` | :arrow_down: |
   | [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `68.93% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `29.62% <0.00%> (ø)` | |
   | [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `82.55% <0.00%> (ø)` | |
   | [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `33.33% <0.00%> (ø)` | |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `14.66% <0.00%> (ø)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.32% <0.00%> (ø)` | |
   | [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `53.96% <0.00%> (+0.42%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9840fbf...e91f70b](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17851:
URL: https://github.com/apache/superset/pull/17851#issuecomment-999692137


   # [Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17851](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c573dbe) into [master](https://codecov.io/gh/apache/superset/commit/9840fbf49be2668553e68aded3d77988077b8565?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9840fbf) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head c573dbe differs from pull request most recent head e91f70b. Consider uploading reports for the commit e91f70b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17851/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17851   +/-   ##
   =======================================
     Coverage   66.98%   66.98%           
   =======================================
     Files        1609     1609           
     Lines       64865    64865           
     Branches     6863     6863           
   =======================================
     Hits        43448    43448           
     Misses      19553    19553           
     Partials     1864     1864           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `53.77% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvRGVja0dMQ29udGFpbmVyLmpzeA==) | `0.00% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9840fbf...e91f70b](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17851:
URL: https://github.com/apache/superset/pull/17851#issuecomment-999692137


   # [Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17851](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c573dbe) into [master](https://codecov.io/gh/apache/superset/commit/9840fbf49be2668553e68aded3d77988077b8565?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9840fbf) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17851/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17851   +/-   ##
   =======================================
     Coverage   66.98%   66.98%           
   =======================================
     Files        1609     1609           
     Lines       64865    64865           
     Branches     6863     6863           
   =======================================
     Hits        43448    43448           
     Misses      19553    19553           
     Partials     1864     1864           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `53.77% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx](https://codecov.io/gh/apache/superset/pull/17851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvRGVja0dMQ29udGFpbmVyLmpzeA==) | `0.00% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9840fbf...c573dbe](https://codecov.io/gh/apache/superset/pull/17851?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774052350



##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/package.json
##########
@@ -32,12 +32,10 @@
     "deck.gl": "8.5.2",
     "jquery": "^3.4.1",
     "lodash": "^4.17.15",
-    "mapbox-gl": "^2.4.0",

Review comment:
       Echoing @villebro's comment, we may need this to be a peer dependency so that the plugin continues to work in contexts outside of Superset. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774300957



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       `mapbox-gl` is a dependency from the `react-map-gl`. The root cause for this issue is that `mapbox-gl` version is incompatible in `legacy-plugin-chart-map-box` and `legacy-preset-chart-deckgl`. 
   
   When we removed `mapbox-gl` in both packages, npm will auto-resolve the conflict. If the user installs those packages as standalone, `mapbox-gl` will install by default.
   
   #### `legacy-plugin-chart-map-box` dependencies tree
   ```
   (superset) yongjie.zhao@:superset-frontend$ npm ls --depth 1 | grep -A 30 'map-box'
   ....
   ....
   ├─┬ @superset-ui/legacy-plugin-chart-map-box@0.18.25 -> ./plugins/legacy-plugin-chart-map-box
   │ ├── @superset-ui/chart-controls@0.18.25 deduped -> ./packages/superset-ui-chart-controls
   │ ├── @superset-ui/core@0.18.25 deduped -> ./packages/superset-ui-core
   │ ├── prop-types@15.7.2 deduped
   │ ├─┬ react-map-gl@4.1.16
   │ │ ├── @babel/runtime@7.15.4 deduped
   │ │ ├── mapbox-gl@0.54.1
   │ │ ├── mjolnir.js@2.5.0
   │ │ ├── prop-types@15.7.2 deduped
   │ │ ├── react-virtualized-auto-sizer@1.0.2 deduped
   │ │ ├── react@16.14.0 deduped invalid: "^15.5.4" from node_modules/omnibar
   │ │ └── viewport-mercator-project@6.2.3 deduped
   │ ├── react@16.14.0 deduped
   │ ├─┬ supercluster@4.1.1
   │ │ └── kdbush@2.0.1
   │ └─┬ viewport-mercator-project@6.2.3
   │   ├── @babel/runtime@7.15.4 deduped
   │   └── gl-matrix@3.3.0
   ....
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r773985785



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       from root `src/node_module` get this module

##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/package.json
##########
@@ -32,12 +32,10 @@
     "deck.gl": "8.5.2",
     "jquery": "^3.4.1",
     "lodash": "^4.17.15",
-    "mapbox-gl": "^2.4.0",

Review comment:
       from root `src/node_module` get this module

##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/package.json
##########
@@ -32,12 +32,10 @@
     "deck.gl": "8.5.2",
     "jquery": "^3.4.1",
     "lodash": "^4.17.15",
-    "mapbox-gl": "^2.4.0",
     "moment": "^2.20.1",
     "mousetrap": "^1.6.1",
     "prop-types": "^15.6.0",
     "react-bootstrap-slider": "2.1.5",
-    "react-map-gl": "^6.1.16",

Review comment:
       from root `src/node_module` get this module




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774017405



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       Could we move these to `peerDependencies` to make sure users of the plugin pull in the relevant deps?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774300957



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       `mapbox-gl` is a dependency from the `react-map-gl`, and `mapbox-gl` is a dependency for `deckgl`. The root cause for this issue is that `mapbox-gl` version is incompatible in `legacy-plugin-chart-map-box` and `legacy-preset-chart-deckgl`. 
   
   When we removed `mapbox-gl` in both packages, npm will auto-resolve the conflict. If the user installs those packages as standalone, `mapbox-gl` will install by default.
   
   ```
   (superset) yongjie.zhao@:superset-frontend$ npm ls --depth 1 | grep -A 30 'map-box'
   ....
   ....
   ├─┬ @superset-ui/legacy-plugin-chart-map-box@0.18.25 -> ./plugins/legacy-plugin-chart-map-box
   │ ├── @superset-ui/chart-controls@0.18.25 deduped -> ./packages/superset-ui-chart-controls
   │ ├── @superset-ui/core@0.18.25 deduped -> ./packages/superset-ui-core
   │ ├── prop-types@15.7.2 deduped
   │ ├─┬ react-map-gl@4.1.16
   │ │ ├── @babel/runtime@7.15.4 deduped
   │ │ ├── mapbox-gl@0.54.1
   │ │ ├── mjolnir.js@2.5.0
   │ │ ├── prop-types@15.7.2 deduped
   │ │ ├── react-virtualized-auto-sizer@1.0.2 deduped
   │ │ ├── react@16.14.0 deduped invalid: "^15.5.4" from node_modules/omnibar
   │ │ └── viewport-mercator-project@6.2.3 deduped
   │ ├── react@16.14.0 deduped
   │ ├─┬ supercluster@4.1.1
   │ │ └── kdbush@2.0.1
   │ └─┬ viewport-mercator-project@6.2.3
   │   ├── @babel/runtime@7.15.4 deduped
   │   └── gl-matrix@3.3.0
   ....
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on a change in pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r773985785



##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
   "dependencies": {
     "@superset-ui/chart-controls": "0.18.25",
     "@superset-ui/core": "0.18.25",
-    "mapbox-gl": "^0.53.0",

Review comment:
       from root `node_module` get this module

##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/package.json
##########
@@ -32,12 +32,10 @@
     "deck.gl": "8.5.2",
     "jquery": "^3.4.1",
     "lodash": "^4.17.15",
-    "mapbox-gl": "^2.4.0",

Review comment:
       from root `node_module` get this module

##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/package.json
##########
@@ -32,12 +32,10 @@
     "deck.gl": "8.5.2",
     "jquery": "^3.4.1",
     "lodash": "^4.17.15",
-    "mapbox-gl": "^2.4.0",
     "moment": "^2.20.1",
     "mousetrap": "^1.6.1",
     "prop-types": "^15.6.0",
     "react-bootstrap-slider": "2.1.5",
-    "react-map-gl": "^6.1.16",

Review comment:
       from root `node_module` get this module




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie merged pull request #17851: fix(deckgl): deckgl unable to load map

Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #17851:
URL: https://github.com/apache/superset/pull/17851


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org