[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #7180: Make DisplayText Non-Mandatory for Various Forms.

["JoaoJandre (via GitHub)" <gi...@apache.org>]

JoaoJandre commented on code in PR #7180:
URL: https://github.com/apache/cloudstack/pull/7180#discussion_r1143904549


##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java:
##########
@@ -60,8 +61,7 @@ public class RegisterTemplateCmd extends BaseCmd implements UserCmd {
 
     @Parameter(name = ApiConstants.DISPLAY_TEXT,
                type = CommandType.STRING,
-               required = true,
-               description = "the display text of the template. This is usually used for display purposes.",
+               description = "The display text of the template, defaults to 'name´.",

Review Comment:
   ```suggestion
                  description = "The display text of the template, defaults to 'name'.",
   ```



##########
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java:
##########
@@ -56,7 +57,7 @@ public class CreateDiskOfferingCmd extends BaseCmd {
     @Parameter(name = ApiConstants.DISK_SIZE, type = CommandType.LONG, required = false, description = "size of the disk offering in GB (1GB = 1,073,741,824 bytes)")
     private Long diskSize;
 
-    @Parameter(name = ApiConstants.DISPLAY_TEXT, type = CommandType.STRING, required = true, description = "alternate display text of the disk offering", length = 4096)
+    @Parameter(name = ApiConstants.DISPLAY_TEXT, type = CommandType.STRING, description = "An alternate display text of the disk offering", length = 4096)

Review Comment:
   ```suggestion
       @Parameter(name = ApiConstants.DISPLAY_TEXT, type = CommandType.STRING, description = "An alternate display text of the disk offering, defaults to 'name'.", length = 4096)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org