You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Michael Wyraz (JIRA)" <ji...@apache.org> on 2009/07/10 15:37:14 UTC

[jira] Created: (TAP5-772) Strange behaviour when filter is mapped to different location that /*

Strange behaviour when filter is mapped to different location that /*
---------------------------------------------------------------------

                 Key: TAP5-772
                 URL: https://issues.apache.org/jira/browse/TAP5-772
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.1.0.5
            Reporter: Michael Wyraz


If the filter is mapped to anything else than /* tapestry is not working correctly anymore. Examples:

If I map the filter to /test/*, every page fails with 404
If I map a Servlet to that URL as well, every page renders but all generated links (resources, page links) are wrong (missing /test/).

I think this behaviour depends on what request.gatPathInfo() returns:
- if no servlet is mapped to the current url, it returns NULL.
- otherwise, the uri minus the servlet's path

So the result of request.getPathInfo() has nothing to do with the filter and should not be used there. Instead, the filter should have an init param which tells where It is mapped to and create a wraped ServletRequest with a customized getPathInfo().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TAP5-772) Strange behaviour when filter is mapped to different location that /*

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789026#action_12789026 ] 

Howard M. Lewis Ship commented on TAP5-772:
-------------------------------------------

This is not currently supported and there's a few places in T5 code (such as URL generation) where it's assumed.

> Strange behaviour when filter is mapped to different location that /*
> ---------------------------------------------------------------------
>
>                 Key: TAP5-772
>                 URL: https://issues.apache.org/jira/browse/TAP5-772
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Michael Wyraz
>
> If the filter is mapped to anything else than /* tapestry is not working correctly anymore. Examples:
> If I map the filter to /test/*, every page fails with 404
> If I map a Servlet to that URL as well, every page renders but all generated links (resources, page links) are wrong (missing /test/).
> I think this behaviour depends on what request.gatPathInfo() returns:
> - if no servlet is mapped to the current url, it returns NULL.
> - otherwise, the uri minus the servlet's path
> So the result of request.getPathInfo() has nothing to do with the filter and should not be used there. Instead, the filter should have an init param which tells where It is mapped to and create a wraped ServletRequest with a customized getPathInfo().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TAP5-772) Strange behaviour when filter is mapped to different location that /*

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789026#action_12789026 ] 

Howard M. Lewis Ship commented on TAP5-772:
-------------------------------------------

This is not currently supported and there's a few places in T5 code (such as URL generation) where it's assumed.

> Strange behaviour when filter is mapped to different location that /*
> ---------------------------------------------------------------------
>
>                 Key: TAP5-772
>                 URL: https://issues.apache.org/jira/browse/TAP5-772
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Michael Wyraz
>
> If the filter is mapped to anything else than /* tapestry is not working correctly anymore. Examples:
> If I map the filter to /test/*, every page fails with 404
> If I map a Servlet to that URL as well, every page renders but all generated links (resources, page links) are wrong (missing /test/).
> I think this behaviour depends on what request.gatPathInfo() returns:
> - if no servlet is mapped to the current url, it returns NULL.
> - otherwise, the uri minus the servlet's path
> So the result of request.getPathInfo() has nothing to do with the filter and should not be used there. Instead, the filter should have an init param which tells where It is mapped to and create a wraped ServletRequest with a customized getPathInfo().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.