You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Ted-Jiang (via GitHub)" <gi...@apache.org> on 2023/02/13 14:51:11 UTC
[GitHub] [arrow-rs] Ted-Jiang opened a new pull request, #3709: [feat] Support `unary_dyn_mut` in arrow-arth.
Ted-Jiang opened a new pull request, #3709:
URL: https://github.com/apache/arrow-rs/pull/3709
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3708.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
After this i will try to implement `add_scalar_dyn_mut` `divide_scalar_dyn_mut` ...
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang closed pull request #3709: [feat] Support `unary_dyn_mut` in arrow-arth.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang closed pull request #3709: [feat] Support `unary_dyn_mut` in arrow-arth.
URL: https://github.com/apache/arrow-rs/pull/3709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3709: [feat] Support `unary_dyn_mut` in arrow-arth.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang commented on code in PR #3709:
URL: https://github.com/apache/arrow-rs/pull/3709#discussion_r1104582980
##########
arrow-arith/src/arity.rs:
##########
@@ -152,6 +152,37 @@ where
}
}
+/// Applies an infallible unary function to an [`ArrayRef`] with primitive values.
+/// If the buffer of ArrayRef is not shared with other arrays, then func will
+/// mutate the buffer directly without allocating new buffer.
+pub fn unary_dyn_mut<F, T>(array: ArrayRef, op: F) -> Result<ArrayRef, ArrayRef>
+where
+ T: ArrowPrimitiveType,
+ F: Fn(T::Native) -> T::Native,
+{
+ let array_ref = array.as_ref();
+ downcast_dictionary_array! {
+ array_ref => unary_dict::<_, F, T>(array_ref, op).map_err(|_| array),
+ t => {
+ //Todo support unary_dict_mut
Review Comment:
File a ticket https://github.com/apache/arrow-rs/issues/3710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on pull request #3709: [feat] Support `unary_dyn_mut` in arrow-arth.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang commented on PR #3709:
URL: https://github.com/apache/arrow-rs/pull/3709#issuecomment-1428070277
Plz take a look 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org