[GitHub] [helix] kaisun2000 commented on a change in pull request #1449: HelixClusterVerifier verify() with default waitTillVerify time -- part one

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1449:
URL: https://github.com/apache/helix/pull/1449#discussion_r501280305



##########
File path: helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -438,7 +441,7 @@ public void testResetSnapshots() {
     Assert.assertEquals(
         changeDetector.getAdditionsByType(ChangeType.IDEAL_STATE).size() + changeDetector
             .getChangesByType(ChangeType.IDEAL_STATE).size() + changeDetector
-            .getRemovalsByType(ChangeType.IDEAL_STATE).size(), 2);
+            .getRemovalsByType(ChangeType.IDEAL_STATE).size(), 1);

Review comment:
       see line 418, 419
   ```
         // remove newly added resource/ideastate
         _gSetupTool.getClusterManagementTool().dropResource(CLUSTER_NAME, resourceName);
   ```
   
   The newly added resource in the previous test is not really valid. Or they would break this test. So in this diff, it is removed.  Accordingly the number here needs to be adjusted too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org