[GitHub] [iceberg] wypoon commented on a diff in pull request #7738: Data: TableMigrationUtil shouldn't use path to get partition values

["wypoon (via GitHub)" <gi...@apache.org>]

wypoon commented on code in PR #7738:
URL: https://github.com/apache/iceberg/pull/7738#discussion_r1212386909


##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -151,6 +256,36 @@ public static List<DataFile> listPartition(
     }
   }
 
+  private static List<FileStatus> fileStatusListInPartition(String partitionUri, Configuration conf)
+      throws IOException {

Review Comment:
   I thought the reason you're defining this helper method is because the same code exists in the existing `listPartitions` that you're retaining but deprecating and the new one you're adding, but you haven't changed the deprecated `listPartitions` to use this helper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org