You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xmlrpc-auto@ws.apache.org by jo...@apache.org on 2006/11/11 23:51:37 UTC

svn commit: r473827 - in /webservices/xmlrpc/trunk: .classpath server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java src/changes/changes.xml

Author: jochen
Date: Sat Nov 11 14:51:36 2006
New Revision: 473827

URL: http://svn.apache.org/viewvc?view=rev&rev=473827
Log:
The configuration framework, as introduced by XMLRPC-116, was applicable
to the configuration only, and not to the XmlRpcServlet, or the
XmlRpcServletServer.
PR: XMLRPC-124
Submitted-by: Jimisola Laursen, lists@jimisola.com

Modified:
    webservices/xmlrpc/trunk/.classpath
    webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java
    webservices/xmlrpc/trunk/src/changes/changes.xml

Modified: webservices/xmlrpc/trunk/.classpath
URL: http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/.classpath?view=diff&rev=473827&r1=473826&r2=473827
==============================================================================
--- webservices/xmlrpc/trunk/.classpath (original)
+++ webservices/xmlrpc/trunk/.classpath Sat Nov 11 14:51:36 2006
@@ -6,6 +6,6 @@
 	<classpathentry kind="src" path="tests/src/test/java"/>
 	<classpathentry kind="src" path="tests/src/test/resources"/>
 	<classpathentry kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER"/>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JDK-1.5.0"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/J2SE-1.4"/>
 	<classpathentry kind="output" path="tests/target/test-classes"/>
 </classpath>

Modified: webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java
URL: http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java?view=diff&rev=473827&r1=473826&r2=473827
==============================================================================
--- webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java (original)
+++ webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java Sat Nov 11 14:51:36 2006
@@ -71,7 +71,9 @@
             String name = (String) en.nextElement();
             String value = pConfig.getInitParameter(name);
             try {
-                if (ReflectionUtil.setProperty(server, name, value)) {
+                if (!ReflectionUtil.setProperty(this, name, value)
+                    &&  !ReflectionUtil.setProperty(server, name, value)
+                    &&  !ReflectionUtil.setProperty(server.getConfig(), name, value)) {
                     throw new ServletException("Unknown init parameter " + name);
                 }
             } catch (IllegalAccessException e) {
@@ -177,8 +179,8 @@
         } else {
             mapping.setTypeConverterFactory(server.getTypeConverterFactory());
         }
-        mapping.load(Thread.currentThread().getContextClassLoader(), url);
         mapping.setVoidMethodEnabled(server.getConfig().isEnabledForExtensions());
+        mapping.load(Thread.currentThread().getContextClassLoader(), url);
         return mapping;
 	}
 

Modified: webservices/xmlrpc/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/src/changes/changes.xml?view=diff&rev=473827&r1=473826&r2=473827
==============================================================================
--- webservices/xmlrpc/trunk/src/changes/changes.xml (original)
+++ webservices/xmlrpc/trunk/src/changes/changes.xml Sat Nov 11 14:51:36 2006
@@ -28,6 +28,12 @@
         Reworked the WebServer/ThreadPool framework in order to ensure a clean
         shutdown.
       </action>
+      <action dev="jochen" type="fix" issue="XMLRPC-124" due-to="Jimisola Laursen"
+          due-to-email="lists@jimisola.com">
+		The configuration framework, as introduced by XMLRPC-116, was applicable
+		to the configuration only, and not to the XmlRpcServlet, or the
+		XmlRpcServletServer.
+      </action>
     </release>
     <release version="3.0.1-SNAPSHOT" date="Not yet released">
       <action dev="jochen" type="fix">