You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by jo...@apache.org on 2007/04/10 22:33:11 UTC

svn commit: r527282 - /cocoon/branches/BRANCH_2_1_X/src/blocks/proxy/java/org/apache/cocoon/generation/WebServiceProxyGenerator.java

Author: joerg
Date: Tue Apr 10 13:33:10 2007
New Revision: 527282

URL: http://svn.apache.org/viewvc?view=rev&rev=527282
Log:
It seems the comment about missing consideration of XML declaration does no longer apply.
For http://marc.info/?t=117615325600006&r=1&w=4 I played around with reactivated wsproxy sample and modified response body byte[] on the fly. The observed error only happened when the actual encoding was ISO-8859-1 and the XML declaration was missing, ie. the XML parsed by default as UTF-8.

Modified:
    cocoon/branches/BRANCH_2_1_X/src/blocks/proxy/java/org/apache/cocoon/generation/WebServiceProxyGenerator.java

Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/proxy/java/org/apache/cocoon/generation/WebServiceProxyGenerator.java
URL: http://svn.apache.org/viewvc/cocoon/branches/BRANCH_2_1_X/src/blocks/proxy/java/org/apache/cocoon/generation/WebServiceProxyGenerator.java?view=diff&rev=527282&r1=527281&r2=527282
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/proxy/java/org/apache/cocoon/generation/WebServiceProxyGenerator.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/proxy/java/org/apache/cocoon/generation/WebServiceProxyGenerator.java Tue Apr 10 13:33:10 2007
@@ -113,11 +113,6 @@
                 this.getLogger().debug("response: " + new String(response));
             }
 
-            /* TODO: Though I avoided the getResponseBodyAsString(), the content
-             *       seems not to be parsed correctly. Who cares about the encoding
-             *       in the XML declaration?
-             * {@link http://jakarta.apache.org/commons/httpclient/apidocs/org/apache/commons/httpclient/HttpMethodBase.html#getResponseBodyAsString()}
-             */
             ByteArrayInputStream responseStream = new ByteArrayInputStream(response);
             InputSource inputSource = new InputSource(responseStream);
             parser = (SAXParser)this.manager.lookup(SAXParser.ROLE);